Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-988] Set devnet max sizes to same as mainnet #3346

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

disassembler
Copy link
Contributor

Description

Fix integration test failures because of not enough coin available.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-988

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@disassembler disassembler requested review from KtorZ and a team and removed request for erikd August 3, 2018 09:01
Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Hopefully would solve some issues.

Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jmitchell jmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a blockVersionData sibling key, so we should merge the settings there instead:

blockVersionData:

Speaking of which, what are the semantics of duplicate sibling keys in YAML anyway?

EDIT: The YAML spec says

The content of a mapping node is an unordered set of key: value node pairs, with the restriction that each of the keys is unique.

@disassembler disassembler force-pushed the devops-988-bump-devnet-tx-size branch from 0be12fa to 1203b12 Compare August 3, 2018 14:14
@disassembler disassembler merged commit 17a809e into develop Aug 6, 2018
@cleverca22 cleverca22 deleted the devops-988-bump-devnet-tx-size branch August 9, 2018 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants