This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1013] bump nixpkgs and add enablePhaseMetrics=true #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disassembler
force-pushed
the
devops-1013-enable-phase-metrics
branch
3 times, most recently
from
f537779
to
f78e26c
Compare
disassembler
force-pushed
the
devops-1013-enable-phase-metrics
branch
3 times, most recently
from
e83da1e
to
da59420
Compare
cleverca22
reviewed
Aug 24, 2018
default.nix
Outdated
| cardanoPkgsBase = ((import ./pkgs { inherit pkgs; }).override { | ||
| ghc = overrideDerivation pkgs.haskell.compiler.ghc822 (drv: { | ||
| patches = drv.patches ++ [ ./ghc-8.0.2-darwin-rec-link.patch ]; | ||
| }); | ||
| }); | ||
|
|
||
| activeOverlays = [ requiredOverlay ] | ||
| ++ [ metricOverlay ] |
There was a problem hiding this comment.
these 2 lines could just be a single list on one line
cleverca22
approved these changes
Aug 24, 2018
disassembler
force-pushed
the
devops-1013-enable-phase-metrics
branch
2 times, most recently
from
b328fff
to
7bcb3ac
Compare
disassembler
force-pushed
the
devops-1013-enable-phase-metrics
branch
from
7bcb3ac
to
72b237d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Phase times metrics for everything!
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1013
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)