Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-213] introduce 'Trace.Named' #3481

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Aug 24, 2018

Description

Alexander Vieth introduced logging in IO with ‘Trace’ in module ‘networking’. Logging does not depend on a monad in the context but is directly done using a passed-in function. This type of logging showed to be very effective, and our computation does not need to be run in a logging monad (on top of the other monads).

The implementation of ‘Pos.Util.Trace.Named’ and its tests reside in module ‘util’. No current code will use this functions.

This PR depends on PR #3476 and PR #3477. Once they are merged, CI tests should succeed.

Linked issue

CBR-213
CBR-97 (user story)

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

No changes to existing code; new code to module ‘util’

CodiePP added a commit that referenced this pull request Aug 25, 2018
…uce-katip-cold

[CBR-207] introduce 'katip' - needed for PR #3481
@CodiePP CodiePP force-pushed the adiemand/CBR-213/introduce-TraceNamed-cold branch from 3251c8c to ae2903b Compare August 25, 2018 20:14
@CodiePP CodiePP removed the wip label Aug 25, 2018
@CodiePP CodiePP force-pushed the adiemand/CBR-213/introduce-TraceNamed-cold branch 4 times, most recently from b773757 to 2784a5c Compare August 27, 2018 18:08
@CodiePP CodiePP force-pushed the adiemand/CBR-213/introduce-TraceNamed-cold branch 2 times, most recently from 5fb262d to 0ba5d8d Compare August 28, 2018 14:00
@CodiePP CodiePP merged commit 711346c into develop Aug 28, 2018
@CodiePP CodiePP deleted the adiemand/CBR-213/introduce-TraceNamed-cold branch October 26, 2018 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants