Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-400] Fix wallet failing to start #3486

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Conversation

ruhatch
Copy link
Contributor

@ruhatch ruhatch commented Aug 25, 2018

Description

CDEC-509 introduced a bug that stopped the wallet from starting. This fixes it by using Maybe GeneratedSecrets where necessary.

Linked issue

CBR-400

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

Copy link

@robahub robahub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add my review?

Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can confirm that this has fixed it.

@erikd
Copy link
Member

erikd commented Aug 26, 2018

Going to merge this.

@erikd erikd merged commit bf712f0 into develop Aug 26, 2018
@erikd erikd deleted the ruhatch/CDEC-509-hotfix branch August 26, 2018 06:13
@input-output-hk input-output-hk deleted a comment from robahub Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants