Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-426] Crashes node upon wallet failure #3584

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Sep 13, 2018

Description

Prior to this commit, an exception in the wallet would simply log an
error message and silently die, keeping the underlying node running.
This is rather unintuitive especially in situation where we don't
necessarily have eyes on logs (e.g. running a demo cluster). When a
node uses the wallet, if the wallet crashes, the node ought to crash as
well.

That is especially true when network binding address is already taken,
which occurs fairly often during development / testing (i.e. a prior
node is still listening to :8090 and the new one fails to bound. Then,
requests are made against a running node which is not the one we
expect!!)

Linked issue

[CBR-426]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

screenshot from 2018-09-13 05-42-52

Prior to this commit, an exception in the wallet would simply log an
error message and silently die, keeping the underlying node running.
This is rather unintuitive especially in situation where we don't
necessarily have eyes on logs (e.g. running a demo cluster).  When a
node uses the wallet, if the wallet crashes, the node ought to crash as
well.

That is especially true when network binding address is already taken,
which occurs fairly often during development / testing (i.e. a prior
node is still listening to :8090 and the new one fails to bound. Then,
requests are made against a running node which is not the one we
expect!!)
@KtorZ KtorZ merged commit b9b115e into develop Sep 14, 2018
@KtorZ KtorZ deleted the KtorZ/CBR-426/crash-node-upon-wallet-failure branch September 14, 2018 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants