This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CDEC-505] Move Pos.Core.Update to Pos.Chain.Update #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruhatch
force-pushed
the
ruhatch/CDEC-505
branch
3 times, most recently
from
fba6bc9
to
18a59ef
Compare
ruhatch
force-pushed
the
ruhatch/CDEC-505
branch
from
18a59ef
to
bce925d
Compare
parsonsmatt
approved these changes
Sep 17, 2018
|
|
||
| instance Arbitrary SystemTag where | ||
| arbitrary = | ||
| oneof . map (pure . SystemTag) $ |
There was a problem hiding this comment.
oneof . map pure === elements ::: [a] -> Gen a
| instance Arbitrary SystemTag where | ||
| arbitrary = | ||
| oneof . map (pure . SystemTag) $ | ||
| [os <> arch | os <- ["win", "linux", "mac"], arch <- ["32", "64"]] |
There was a problem hiding this comment.
Maybe it is prejudice, but I'd rather see liftA2 mappend ["win", "linux", "mac"] ["32", "64] than a list comprehension
There was a problem hiding this comment.
I agree, or (<>) <$> ["win", "linux", "mac"] <*> ["32", "64"]
| genSystemTag = SystemTag <$> Gen.text (Range.constant 0 10) Gen.alphaNum | ||
|
|
||
| genUpAttributes :: Gen UpAttributes | ||
| genUpAttributes = pure $ mkAttributes () |
There was a problem hiding this comment.
This seems wrong. This is only going to test "empty" attributes. Are those the only attributes we ever have in the system with this type?
There was a problem hiding this comment.
So far yes - the Attributes type is for extending records that are stored in the blockchain
| -- <*> genUpId | ||
| -- <*> Gen.bool | ||
| -- <*> genSignature ((,) <$> genUpId <*> Gen.bool) | ||
| -- genUpdateVote pm = mkUpdateVote pm <$> arbitrary <*> arbitrary <*> arbitrary |
ruhatch
force-pushed
the
ruhatch/CDEC-505
branch
from
bce925d
to
2a19d8c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last step of CDEC-505, moving
Pos.Core.Updatemodule set to thechainpackageLinked issue
CDEC-505
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)