This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DDW-318] Remove pretty-encoding for JSONValidationError #3619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is inherited from the old times but is actually wrong.
Pretty encoding is good for human to look at, but when it comes
to parsers, newlines aren't much appreciated (e.g. Daedalus parser).
Curious that this was never caught before, probably because
JSONValidationError weren't really caught by Daedalus. Now some of
them are so we better have well-formed responses :)
Linked issue
[DDW-318]
Type of change
Developer checklist
Testing checklist
[ ] I have added tests to cover my changes.QA Steps
With cURL, an invalid request to trigger a JSONValidationFailed (e.g. using the example mnemonic) returns a response that is correctly encoded.
Screenshots (if available)