Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-97] logging configuration for Daedalus with structured logging #3645

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Sep 21, 2018

Description

Daedalus now expects the node's public log files in $log_prefix/pub in JSON format.

this is a prerequisite for end-to-end tests

Linked issue

CBR-97
DDW-413

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • [~] I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

end-to-end test with log submission to ReportServer

Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@CodiePP CodiePP force-pushed the adiemand/CBR-97/structured_logging-config-Daedalus branch from 96d418b to c8f69b5 Compare September 26, 2018 11:43
@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 26, 2018

rebased on develop
now, we would like to continue with Daedalus end-to-end tests

@CodiePP CodiePP merged commit e3f41a9 into develop Sep 26, 2018
@CodiePP CodiePP deleted the adiemand/CBR-97/structured_logging-config-Daedalus branch September 26, 2018 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants