Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CO-400] Fix exit code acquiring in nix integration tests #3680

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Sep 28, 2018

Description

Since a1e7e80 introduced a pipe after stack test, we were
wrongly getting the status from the tee command instead.

Linked issue

[CO-400]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • [ ] If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [ ] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

Since a1e7e80 introduced a pipe after `stack test`, we were
wrongly getting the status from the `tee` command instead.
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be rebased to accomodate #3678
In https://hydra.iohk.io/build/260699/log we see that as some tests fail the integration test is red, rather than green as previously

@KtorZ
Copy link
Contributor Author

KtorZ commented Sep 28, 2018

No need to rebase here. We can just merge it into develop 👍, CI just picked an old develop.

@KtorZ KtorZ merged commit a4fc7f3 into develop Sep 28, 2018
@KtorZ KtorZ deleted the KtorZ/CO-400/fix-exit-code-integration-tests branch September 28, 2018 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants