Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-1067] [nix] Split overlays into their own files #3690

Merged
merged 3 commits into from
Oct 3, 2018
Merged

[DEVOPS-1067] [nix] Split overlays into their own files #3690

merged 3 commits into from
Oct 3, 2018

Conversation

angerman
Copy link
Contributor

@angerman angerman commented Oct 1, 2018 •
edited
Loading

This is a pure refactoring of the nix logic. The primary goal is
to modularize the overlays and subsequently make rebasing easier by
removing these lines from the default.nix.

Description

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@angerman
Copy link
Contributor Author

angerman commented Oct 1, 2018

🧐

@angerman angerman changed the title [nix] Split overlays into their own files [DEVOPS-1067] [nix] Split overlays into their own files Oct 1, 2018
@angerman
[nix] Split overlays into their own files
1971f92 
This is a pure refactoring of the nix logic.  The primary goal is
to modularize the overlays and subsequently make rebasing easier by
removing these lines from the `default.nix`.
@rvl
nix overlays: Fix build and use nixpkgs style
2d0604a 
- Provide pkgs as top-level attribute so that it can be shared.
- Fix build of set-git-rev
- Use the overlay function arguments style of
  <nixpkgs/pkgs/development/haskell-modules> where arguments other than
  self and super are named.
@rvl
fixup! nix overlays: Fix build and use nixpkgs style
acde183
@angerman
Copy link
Contributor Author

angerman commented Oct 2, 2018

@rvl, this looks good to me. Let's get a review from @cleverca22 and merge if he's ok with it as well?

rvl
rvl approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help clean up top-level default.nix

@angerman angerman merged commit 336e531 into develop Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvl rvl rvl approved these changes

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angerman @rvl