Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-623] Add golden tests for Undo #3735

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[CDEC-623] Add golden tests for Undo #3735

merged 1 commit into from
Oct 12, 2018

Conversation

ruhatch
Copy link
Contributor

@ruhatch ruhatch commented Oct 10, 2018

Description

The Undo type, an important part of the serialized blockchain, isn't golden/round-trip tested. This PR adds golden and round-trip testing for it. A future PR could add further tests to the types that Undo involves, but those weren't added here for expedience.

Linked issue

CDEC-623

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@ruhatch ruhatch self-assigned this Oct 10, 2018
@ruhatch ruhatch merged commit 5c4688e into develop Oct 12, 2018
@ruhatch ruhatch deleted the ruhatch/CDEC-623 branch October 12, 2018 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants