Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-1097] resolved ambiguous types #3764

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Oct 18, 2018

Description

resolved ambiguous type; the logging message was looping inifinitely and never delivered.

Linked issue

DEVOPS-1097

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • [~] All new and existing tests passed.

QA Steps

these steps should be done in the root directory of where cardano-sl was checkout:

1.) compilation: nix-build -A connectScripts.mainnet.wallet --arg forceDontCheck true --cores 0 --max-jobs 4
2.) create file: default-wallet.key with permissions e.g. 755: chmod 755 default-wallet.key
3.) run in one terminal: ./result
4.) run in another terminal: curl -v https://localhost:8090/api/internal/import-wallet -k --cert state-wallet-mainnet/tls/client/client.crt --key state-wallet-mainnet/tls/client/client.key -d '{"filePath":"<<enter absolute path to >>/default-wallet.key"}' -H 'Content-Type: application/json'

Screenshots (if available)

a log entry appears similar to this one:

[cardano-sl.*production*:Warning:ThreadId 389] [2018-10-18 08:05:36.70 UTC] Key file at <<path>>/cardano-sl.git/default-wallet.key has access mode 755 instead of 600. Fixing it automatically.

Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@CodiePP CodiePP self-assigned this Oct 18, 2018
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@CodiePP
Copy link
Contributor Author

CodiePP commented Oct 19, 2018

the liftIO is actually not necessary.
together with @365andreas we debugged and traced this to the use site in wallet-new where the function readUserSecret calling ensureModeIs600 was called within a monad KeystoreM (actually IO). This then let to the confusion in the compiler.
Along the way we also found an instance HasLoggerName IO in core which we moved to the correct place in util.

@CodiePP CodiePP merged commit 18c73d3 into develop Oct 22, 2018
@CodiePP CodiePP deleted the adiemand/devops-1097-daedalus-tests-hang-backend branch October 22, 2018 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants