This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1099] make the wallet documentation optional, and default it to off #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about |
KtorZ
suggested changes
Oct 20, 2018
| -- The corresponding wallet documention, served as a different | ||
| -- server which doesn't require client x509 certificates to | ||
| -- connect, but still serves the doc through TLS | ||
| , maybe [] (\x -> [x]) (Plugins.docServer params) |
There was a problem hiding this comment.
Why moving the worker's name outside?
, maybe [] (pure . ("doc server",)) (Plugins.docServer params)| docServer (NewWalletBackendParams WalletBackendParams{..}) = const $ | ||
| serveDocImpl | ||
| -> Maybe (Text, Plugin Kernel.WalletMode) | ||
| docServer (NewWalletBackendParams WalletBackendParams{..}) = maybe Nothing (\addr -> Just ("doc worker", makeWalletServer addr)) walletDocAddress |
There was a problem hiding this comment.
Cf comment above :)
= makeWalletServer <$> walletDocAddress
disassembler
approved these changes
Oct 31, 2018
|
Target Version is 2.0.0 |
cleverca22
force-pushed
the
devops-1099
branch
from
acc0557
to
1d82b61
Compare
cleverca22
force-pushed
the
devops-1099
branch
from
1d82b61
to
cf68c04
Compare
KtorZ
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
by default, it binds to
127.0.0.1:8091and there is no way to turn it off, causing conflicts whenever you try to run 2 wallets at onceLinked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)