Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DDW-480] Fix error message show user for x509 regeneration failures #3834

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

disassembler
Copy link
Contributor

Description

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run this by TS.
What does "Please check your configuration mean" for a user who sees the error message?

@disassembler disassembler force-pushed the ddw-480-fix-error-msg branch 2 times, most recently from 3933ae2 to fdf1bdb Compare November 7, 2018 14:04
@nikolaglumac
Copy link

@darko-mijic can you please check the text change @disassembler wants to introduce in this PR?
Thanks!

@deepfire deepfire merged commit 491bdc6 into develop Nov 8, 2018
@deepfire deepfire deleted the ddw-480-fix-error-msg branch November 8, 2018 11:31
@KtorZ KtorZ mentioned this pull request Jan 4, 2019
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants