Karknu/rcd 43 mitigation

[karknu]

Description

Improvement that makes the network disconnect in RCD-43 less likely to happen.

Linked issue

Type of change

• 🐞 Bug fix (non-breaking change which fixes an issue)
• 🛠 New feature (non-breaking change which adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
• 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
• 🔨 New or improved tests for existing code
• ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

• I have read the style guide document, and my code follows the code style of this project.
• If my code deals with exceptions, it follows the guidelines.
• I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
• CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

• I have added tests to cover my changes.
• All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

[dcoutts]

Looks good. One minor comment on the tidy-up requested. Otherwise we can proceede.

[jmitchell]

bors r+

[iohk-bors]

Build failed (retrying...)

• ci/hydra:serokell:cardano-sl:required

[jmitchell]

src/Pos/DB/Rocks/Functions.hs:97:5: error:
    • Couldn't match type ‘m’ with ‘IO’
      ‘m’ is a rigid type variable bound by
        the type signature for:
          openNodeDBs :: forall (m :: * -> *).
                         MonadIO m =>
                         Bool -> FilePath -> m NodeDBs
        at src/Pos/DB/Rocks/Functions.hs:(72,1)-(74,36)
      Expected type: m ()
        Actual type: IO ()
    • In a stmt of a 'do' block:
        when (System.Info.os == "darwin")
          $ withFile
              (fp </> ".metadata_never_index") AppendMode (\ _ -> return ())
      In the expression:
        do liftIO
             $ whenM ((recreate &&) <$> doesDirectoryExist fp)
                 $ removeDirectoryRecursive fp
           let blocksDir = fp </> "blocks"
           let blocksIndexPath = blocksDir </> "index"
           let _blockDataDir = blocksDir </> "data"
           ....
      In an equation for ‘openNodeDBs’:
          openNodeDBs recreate fp
            = do liftIO
                   $ whenM ((recreate &&) <$> doesDirectoryExist fp)
                       $ removeDirectoryRecursive fp
                 let blocksDir = ...
                 let blocksIndexPath = ...
                 ....
            where
                ensureDirectoryExists :: MonadIO m => FilePath -> m ()
                ensureDirectoryExists = liftIO . createDirectoryIfMissing True
    • Relevant bindings include
        openNodeDBs :: Bool -> FilePath -> m NodeDBs
          (bound at src/Pos/DB/Rocks/Functions.hs:75:1)
   |
97 |     when (System.Info.os == "darwin") $
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

[iohk-bors]

Canceled

[jmitchell]

bors r+

[iohk-bors]

Canceled

[jmitchell]

bors r+

[iohk-bors]

Timed out

[jmitchell]

bors r+ p=10

[iohk-bors]

Timed out

[cleverca22]

bors r+ p=10

[iohk-bors]

Build succeeded

• ci/hydra:serokell:cardano-sl:required
• buildkite/cardano-sl