Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-1134] use text backend for conenctScripts logging config (#3856) #3979

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

disassembler
Copy link
Contributor

(cherry picked from commit b49b9de)

Description

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

, severity: Debug+
, backend: FileTextBE }
- { name: "Secret"
, filepath: "node"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node.log?

@disassembler
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 21, 2018
3973: RCD-43 cherry picks r=karknu a=karknu

## Description

Cherry pick RCD-43 fixes from release/2.0.0.

<!--- A brief description of this PR and the problem is trying to solve -->

## Linked issue
https://iohk.myjetbrains.com/youtrack/issue/RCD-43
<!--- Put here the relevant issue from YouTrack -->



3979: [DEVOPS-1134] use text backend for conenctScripts logging config (#3856) r=disassembler a=disassembler

(cherry picked from commit b49b9de)

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
Co-authored-by: Duncan Coutts <duncan.coutts@iohk.io>
Co-authored-by: Samuel Leathers <disasm@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 21, 2018

@iohk-bors iohk-bors bot merged commit 43a359f into develop Dec 21, 2018
@iohk-bors iohk-bors bot deleted the release-2-develop-cherry-sam branch December 21, 2018 18:17
@KtorZ KtorZ mentioned this pull request Jan 4, 2019
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants