This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
add extra guard to fail if trying to submit a too big transaction #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen because we only _estimate_ the maximum number of inputs allowed for the coin selection. As a result, the transaction generated as a result of the coin selection may be slightly bigger than the maximum sized allowed by the network (currently 8kb). So, having an extra sanity checks prevent wrong transactions to be submitted (and added to our pendin set)
piotr-iohk
reviewed
May 7, 2019
| Right meta -> return $ Right (taTx $ txAux, meta) | ||
| let sz = fromIntegral $ BL.length $ serialize txAux | ||
| maxSz <- Node.getMaxTxSize (walletPassive activeWallet ^. walletNode) | ||
| if sz > maxSz then |
There was a problem hiding this comment.
@KtorZ, just to make sure, we don't need sz >= maxSz here (most probably not, but asking just to be safe :) )
There was a problem hiding this comment.
I am not sure how cardano-sl approaches maximum actually and whether it treats it as an inclusive or exclusive boundary 🤔 ...
KtorZ
commented
May 10, 2019
| @@ -177,7 +177,7 @@ pay activeWallet spendingPassword opts accountId payees = do | |||
| Right (txAux, partialMeta, _utxo) -> do | |||
| let sz = fromIntegral $ BL.length $ serialize txAux | |||
| maxSz <- Node.getMaxTxSize (walletPassive activeWallet ^. walletNode) | |||
| if sz > maxSz then | |||
| if sz >= maxSz then | |||
|
@piotr-iohk can you approve the PR so I can merge it? |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 13, 2019
4131: add extra guard to fail if trying to submit a too big transaction r=disassembler a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> This can happen because we only _estimate_ the maximum number of inputs allowed for the coin selection. As a result, the transaction generated as a result of the coin selection may be slightly bigger than the maximum sized allowed by the network (currently 8kb). So, having an extra sanity checks prevent wrong transactions to be submitted (and added to our pendin set) ## Linked issue <!--- Put here the relevant issue from YouTrack --> ? Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 13, 2019
4131: add extra guard to fail if trying to submit a too big transaction r=disassembler a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> This can happen because we only _estimate_ the maximum number of inputs allowed for the coin selection. As a result, the transaction generated as a result of the coin selection may be slightly bigger than the maximum sized allowed by the network (currently 8kb). So, having an extra sanity checks prevent wrong transactions to be submitted (and added to our pendin set) ## Linked issue <!--- Put here the relevant issue from YouTrack --> ? Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Samuel Leathers <samuel.leathers@iohk.io>
Build succeeded |
disassembler
added a commit
that referenced
this pull request
May 22, 2019
jbgi
pushed a commit
that referenced
this pull request
Jun 3, 2019
jbgi
pushed a commit
that referenced
this pull request
Jun 3, 2019
12 tasks
jbgi
pushed a commit
that referenced
this pull request
Jun 11, 2019
jbgi
pushed a commit
that referenced
this pull request
Jun 11, 2019
jbgi
pushed a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can happen because we only estimate the maximum number of inputs allowed for the coin selection.
As a result, the transaction generated as a result of the coin selection may be slightly bigger than
the maximum sized allowed by the network (currently 8kb). So, having an extra sanity checks prevent
wrong transactions to be submitted (and added to our pendin set)
Linked issue
?
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.