This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
Review Fee Calculation (Backport from Cardano-SL) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, basically, by conflating a bit the selected entries and changes, a lot of things become easier. At the price of one thing: fairness. The previous code was splitting fee across change proportionally to inputs. So here, I just split the fee across all changes, regardless of the input. So everyone's got to pay the same part of for the transaction. One could see it as another type of fairness 🙃 ... But that's also a lot simpler to handle, because we can just manipulate all inputs and all changes directly and compute fee for those directly.
parsonsmatt
previously requested changes
Nov 21, 2018
|
|
||
| let neInps = case inps' of | ||
| [] -> error "adjustForFees: empty list of inputs" | ||
| i:is -> i :| is |
There was a problem hiding this comment.
CoinSelT has an error branch. We should be using that instead of error.
There was a problem hiding this comment.
Note that here, those aren't error case we want to handle but actual invariant violation.
The kerbel uses this error "pattern" in multiple places to put light on invariant. This is not something we want to shove in our error type.
|
|
||
| let neOuts = case outs' of | ||
| [] -> error "adjustForFees: empty list of outputs" | ||
| o:os -> o :| os |
denisshevchenko
approved these changes
Nov 26, 2018
KtorZ
dismissed
parsonsmatt’s stale review
dismissing remaining review comments: not sure if you're in Regensburg training or not? Plus. this is really just a backport from cardano-sl so I'd rather have no conceptual changes done within this PR; but rather in a second one as a follow-up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
input-output-hk/cardano-sl/pull/3861
Acceptance criteria:
¯\_(ツ)_/¯
Comments
This is just a backport of the fix done in
cardano-sl/developandcardano-sl/release-2.0.0until we get this submodules setup correctly done....Checklist