Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments on non-top-level entities. #36

Closed
nc6 opened this issue Aug 26, 2024 · 1 comment
Closed

Allow comments on non-top-level entities. #36

nc6 opened this issue Aug 26, 2024 · 1 comment
Labels
Huddle Issues relating to the Huddle language

Comments

@nc6
Copy link
Collaborator

nc6 commented Aug 26, 2024

Currently Huddle supports comments only on rules. It would be good to allow them anywhere, or at least in more places.

@nc6 nc6 added the Huddle Issues relating to the Huddle language label Aug 26, 2024
nc6 added a commit that referenced this issue Nov 22, 2024
This addresses part of #36 - comments are still not supported
_everywhere_, but they are allowed on group entries, which represent the
area (other than top-level rules) where comments are the most useful.

The same "comment" syntax is used as with top-level rules.

Note that this does not (yet) work within groups - that will be
addressed as part of #32.

As yet, the parser still does not deal with comments, or attribute them
to any entity. The tests are likewise oblivious to comments. But this
does allow Huddle to define comments and have them reflected in the
generated CDDL, which was the principal outcome.
@nc6
Copy link
Collaborator Author

nc6 commented Nov 22, 2024

Marking this as addressed by #41. We could allow comments elsewhere, but I think this is enough to now.

@nc6 nc6 closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Huddle Issues relating to the Huddle language
Projects
None yet
Development

No branches or pull requests

1 participant