Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-388] Detect if Daedalus was launched using Launcher #1054

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Aug 17, 2018

This PR implements an error dialog shown in case Daedalus was NOT started using Launcher.exe on Windows platform.

Todo:

  • Implement platform specific error messages

Screenshots:

MacOS / Linux

screen shot 2018-08-20 at 10 14 30

Windows

screen shot 2018-08-20 at 10 15 23


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac
Copy link
Contributor Author

@darko-mijic can you please check the alert dialog content?

@darko-mijic
Copy link
Contributor

Let's change the copy to:

Daedalus improperly started!
Please start Daedalus using the icon in the Windows start menu or using Daedalus icon on your desktop.

@nikolaglumac
Copy link
Contributor Author

@darko-mijic I have updated the copy BUT since we will show this error message on all platforms (not only Windows) we need either:
A) a platform generic error message
B) 3 different platform specific error messages

@nikolaglumac nikolaglumac removed the WIP label Aug 20, 2018
@nikolaglumac
Copy link
Contributor Author

MacOS / Linux message:
screen shot 2018-08-20 at 10 14 30

Windows:
screen shot 2018-08-20 at 10 15 23

@nikolaglumac
Copy link
Contributor Author

@darko-mijic @cleverca22 @deepfire this PR is now ready for review!

@nikolaglumac
Copy link
Contributor Author

@cleverca22 @deepfire guys please review this one - we need approval from at least one Devops team member. Thanks! 🙏

@nikolaglumac
Copy link
Contributor Author

Alan has tested windows build and confirmed that the fix works as expected. Merging this PR now...

@nikolaglumac nikolaglumac merged commit 5a580cd into release/0.11.1 Aug 21, 2018
@nikolaglumac nikolaglumac deleted the fix/ddw-388-detect-if-daedalus-was-launched-using-launcher branch August 21, 2018 19:31
@nikolaglumac nikolaglumac mentioned this pull request Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants