-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-388] Detect if Daedalus was launched using Launcher #1054
[DDW-388] Detect if Daedalus was launched using Launcher #1054
Conversation
@darko-mijic can you please check the alert dialog content? |
Let's change the copy to: Daedalus improperly started! |
…date error message and title
@darko-mijic I have updated the copy BUT since we will show this error message on all platforms (not only Windows) we need either: |
…-launched-using-launcher
…-launched-using-launcher
@darko-mijic @cleverca22 @deepfire this PR is now ready for review! |
…-launched-using-launcher
@cleverca22 @deepfire guys please review this one - we need approval from at least one Devops team member. Thanks! 🙏 |
Alan has tested windows build and confirmed that the fix works as expected. Merging this PR now... |
This PR implements an error dialog shown in case Daedalus was NOT started using Launcher.exe on Windows platform.
Todo:
Screenshots:
MacOS / Linux
Windows
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board