-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-360] missing v1 api endpoints integration 6-9 #1079
[DDW-360] missing v1 api endpoints integration 6-9 #1079
Conversation
}`; | ||
} else if (statusCode === 400) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcusHurney are you sure the expected statusCode is 400
?
In the docs it says it should be 404
- AKA not-found?
Also, I am a bit worried that any other status code 400/404 will not be properly handled with this if clause. E.g. other endpoints might have status 400 as real error?
@MarcusHurney the reason this endpoint was returning error code 400 is the fact you are running the backend against the old data layer. I have tested it against the new data layer and I got the expected 404 error code. Since we will switch to the new data layer I have updated the code: ffe3538 |
@MarcusHurney V1 Api endpoint |
@MarcusHurney I have tested the next-update endpoint and it works correctly 👍 |
@nikolaglumac |
This PR implements V1 endpoints for the follow Ada API requests:
6.) nextAdaUpdate.js
request.js
for a 404 response which indicates an update is not available instead of an error.7.) applyAdaUpdate.js
8.) postponeAdaUpdate.js
9.) adaTestReset.js
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board