-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-321] Clean Up V1 API Code Base #1088
Merged
nikolaglumac
merged 31 commits into
feature/ddw-321-v1-api-integration
from
feature/ddw-321-clean-up-v1-api-code-base
Sep 18, 2018
Merged
[DDW-321] Clean Up V1 API Code Base #1088
nikolaglumac
merged 31 commits into
feature/ddw-321-v1-api-integration
from
feature/ddw-321-clean-up-v1-api-code-base
Sep 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansactions.js domain
…eviously api/ada/index.js
… resolves merge conflicts
nikolaglumac
approved these changes
Sep 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @MarcusHurney 🎉 🎉 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes depreciated types, requests, and API methods associated with the V0 API.
Remove the now unnecessary
Ada
prefix from types, requests, and variables that was previously used to differentiate fromETC
related data.Within the
/api
directory, organizes requests, types, and errors into subdirectories based on the categoriesAccounts
,Addresses
,Common
,Nodes
,Transactions
, andWallets
.Consolidates API related utility functions that were previously scattered around into one directory
/api/utils
.Updates the flow type and error import names in
/components
,/stores
, and/domains
where ever they are used.Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board