Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-503] Hide transaction status and number of confirmations during wallet restoration #1189

Conversation

nikolaglumac
Copy link
Contributor

This PR hides transaction status and number of confirmations during wallet restoration as the old data layer restoration showed old transactions with their current/fresh status and number of confirmations while the new data layer changes the status and number of confirmations in a fast-forward manner as it processes the blockchain starting from the genesis block. Thus the old transactions would show up initially with the pending status which is confusing to the users.

Screenshots:

Wallet Summary during restoration:

Wallet pending transaction amounts are hidden and transactions are shown without the status and confirmation number information.

screen shot 2018-11-22 at 16 38 26

Wallet Summary after restoration:

screen shot 2018-11-22 at 16 36 09

Wallet Transactions screen during restoration:

Transactions are shown without the status and confirmation number information.

screen shot 2018-11-22 at 16 38 19

Wallet Transactions screen after restoration:

screen shot 2018-11-22 at 16 36 19


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac
Copy link
Contributor Author

BK build hasn't failed - GH has wrong link - this is the correct build: https://buildkite.com/input-output-hk/daedalus/builds/3529 (GH will update the BK status once build is done)...

@amias-iohk
Copy link
Contributor

verified the linux build against mainnet.

  • nothing said pending
  • no labels were shown during restore
  • labels where shown as soon a restore finished
  • checked both summary and the transactions views
  • transaction assurance level is empty during restore
  • transaction count was same all the way through
  • nothing looks unusual visually

this resolves and RCD-50
#1189 DDW-503

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@nikolaglumac
Copy link
Contributor Author

Thanks for the approvals @DominikGuzei and @amias-iohk. Before we merge this one we need to get a final approval from @darko-mijic regarding the UI changes 🙏

@nikolaglumac nikolaglumac merged commit e36639f into release/0.12.0 Nov 22, 2018
@nikolaglumac nikolaglumac deleted the fix/ddw-503-hide-transaction-status-and-number-of-confirmations-during-wallet-restoration branch November 22, 2018 18:22
@nikolaglumac nikolaglumac mentioned this pull request Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants