Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-459] Replace in-app support request with links to support page #1199

Conversation

thedanheller
Copy link
Contributor

@thedanheller thedanheller commented Nov 27, 2018

This PR replaces in-app support request with links to the support and loading screens.

Information sent:

The link will receive some information via query strings, as below:

{
  "frontendVersion": "0.11.1",
  "backendVersion": "1.3.2",
  "network": "staging",
  "build": "dev",
  "installerVersion": "...",
  "os": "macOS",
  "locale": "en-US",
  "product": "Daedalus wallet - staging",
  "supportLanguage": "English",
  "productVersion": "Daedalus 0.11.1+Cardano 1.3.2"
}

Link example:

https://iohk.zendesk.com/hc/en-us/categories/360000877653-Daedalus-wallet-mainnet?frontendVersion=0.12.0&backendVersion=dev&network=staging&build=dev&installerVersion=dev&os=macOS&locale=en-US&product=Daedalus%20wallet%20-%20staging&supportLanguage=English&productVersion=Daedalus%200.12.0%2BCardano%20dev

Todo:

  • Support link URL - Carl Shepard

Settings > Support page

  • Replace the current action with the link to the support page

Connecting screen > Having trouble notification

  • Replace the action and also
  • Add "download the logs locally" additional link

Screenshots:

image


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@thedanheller
Copy link
Contributor Author

thedanheller commented Nov 28, 2018

image

@a-rukin currently the connecting screen has a dark background. How should I proceed, changing to the light color in the Zeplin layout or keeping as it is? If it's the second choice, could you provide the Download Logs colors for normal and hover states?

cc @nikolaglumac

@thedanheller
Copy link
Contributor Author

Still missing the final URL and an answer from @a-rukin if the Loading screen should have a white background, but it can be reviewed already.

@nikolaglumac
Copy link
Contributor

@daniloprates we show the same notification on connecting (blue) and syncing (grey) screen.
We should not change any colors in the scope of this PR. The task is only about removing in-app support request code and adding this new link "Download logs" on the notification itself.

could you provide the Download Logs colors for normal and hover states?

There should be no color change on this link. The behavior should be the same as for the links on the Support screen:
screen shot 2018-11-30 at 09 29 32

@nikolaglumac
Copy link
Contributor

@daniloprates aren't you missing an icon in the "Open support ticket" button?
screen shot 2018-11-30 at 09 31 14

Regarding the support link URL - we should discuss this with Carl. This will not be a simple link - we will need to pass a set of query params which will carry over important data to the support page. Please ping me once you start working today and I'll explain the details.

@alexander-rukin
Copy link
Contributor

image

@thedanheller
Copy link
Contributor Author

Hey @nikolaglumac!

we show the same notification on connecting (blue) and syncing (grey) screen.

Sure, I didn't realise the "Having trouble syncing?" message could be shown in the syncing screen. I'll add this state for the Download Logs link.

Regarding the support link URL - we should discuss this with Carl.

Cool, I remember the discussion. I'll ping you.

aren't you missing an icon in the "Open support ticket" button?

The icon is there. Isn't it appearing for you? Maybe I missed something.

image

@thedanheller
Copy link
Contributor Author

@a-rukin thanks, fixed.

@nikolaglumac
Copy link
Contributor

Looks great now @daniloprates 👍

@DominikGuzei
Copy link
Member

Also reviewing this now …

DominikGuzei
DominikGuzei previously approved these changes Nov 30, 2018
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍
One improvement might be good though: Show some kind of success info when the logs have been saved (currently nothing happens). Any thoughts @nikolaglumac @a-rukin @daniloprates?

PS: of we can also do that in a separate work stream.

@nikolaglumac
Copy link
Contributor

@DominikGuzei I don't think we can capture that event as it happens in 2 steps:

  1. You need to select location for the file on disk and click "OK" (this event we can capture!)
  2. Then the actual file gets saved to that location and this operation can take a while (this event I doubt we can capture)

@DominikGuzei
Copy link
Member

DominikGuzei commented Nov 30, 2018

@nikolaglumac
Copy link
Contributor

Hmmmm - yes. I was wrong 😱
Thanks for clearing that up!

@DominikGuzei
Copy link
Member

Yeah i think that info (that it was successful) is important because i was actually wondering if anything happened after i chose the file location.

@nikolaglumac
Copy link
Contributor

We need a concept and design for that. Let's do it in a different task.
@DominikGuzei may I ask you to create a YT ticket for this? 🙏

@thedanheller
Copy link
Contributor Author

@nikolaglumac I was waiting for some feedback or adjustments request, but I guess we can finish this one and treat any future requests as new cards.

@nikolaglumac nikolaglumac removed the WIP label Dec 12, 2018
@DominikGuzei
Copy link
Member

DominikGuzei commented Dec 18, 2018

@daniloprates when trying the latest version locally (dev) im getting this URL:
https://iohk.zendesk.com/hc/en-us/categories/360000877653-Daedalus-wallet-mainnet?frontendVersion=0.12.0&backendVersion=undefined&network=undefined&build=dev&installerVersion=dev&os=macOS&locale=en-US&product=Daedalus%20wallet%20-%20undefined&supportLanguage=English&productVersion=Daedalus%200.12.0%2BCardano%20dev

Seems like a couple of things are undefined, is that expected?

@thedanheller
Copy link
Contributor Author

@DominikGuzei thanks, variable names updated.

@nikolaglumac
Copy link
Contributor

@daniloprates can you please update the support page URLs?

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @daniloprates 👍

@nikolaglumac
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 27, 2018
1199: [DDW-459] Replace in-app support request with links to support page r=nikolaglumac a=daniloprates

This PR replaces in-app support request with links to the support and loading screens.

### Information sent:

The link will receive some information via query strings, as below:

```
{
  "frontendVersion": "0.11.1",
  "backendVersion": "1.3.2",
  "network": "staging",
  "build": "dev",
  "installerVersion": "...",
  "os": "macOS",
  "locale": "en-US",
  "product": "Daedalus wallet - staging",
  "supportLanguage": "English",
  "productVersion": "Daedalus 0.11.1+Cardano 1.3.2"
}
```

Link example:

`https://iohk.zendesk.com/hc/en-us/categories/360000877653-Daedalus-wallet-mainnet?frontendVersion=0.12.0&backendVersion=dev&network=staging&build=dev&installerVersion=dev&os=macOS&locale=en-US&product=Daedalus%20wallet%20-%20staging&supportLanguage=English&productVersion=Daedalus%200.12.0%2BCardano%20dev`


## Todo:

- [x] Support link URL - **Carl Shepard**

### Settings > Support page
- [x] Replace the current action with the link to the support page

### Connecting screen > Having trouble notification
- [x] Replace the action and also 
- [x] Add "download the logs locally" additional link


## Screenshots:

![image](https://user-images.githubusercontent.com/1504716/49180179-107c4600-f33b-11e8-8e24-c8382b532c97.png)


---

## Review Checklist:

### Basics

- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)
- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)
- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)
- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)
- [ ] There are no *lint* errors or warnings (`yarn run lint`)
- [ ] Text changes are proofread and approved (Jane Wild)
- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)
- [ ] UI changes look good in all themes (Alexander Rukin)
- [ ] Storybook works and no stories are broken (`yarn run storybook`)
- [ ] In case of dependency changes `yarn.lock` file is updated

### Code Quality
- [ ] Important parts of the code are properly documented and commented
- [ ] Code is properly typed with flow
- [ ] React components are split-up enough to avoid unnecessary re-rendering
- [ ] Any code that only works in Electron is neatly separated from components

### Testing
- [ ] New feature / change is covered by acceptance tests
- [ ] All existing acceptance tests are still up-to-date
- [ ] New feature / change is covered by Daedalus Testing scenario
- [ ] All existing Daedalus Testing scenarios are still up-to-date

### After Review:
- [ ] Merge PR
- [ ] Delete source branch
- [ ] Move ticket to `done` on the Youtrack board


Co-authored-by: Danilo Prates <daniloprates@gmail.com>
Co-authored-by: Nikola Glumac <niglumac@gmail.com>
Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 27, 2018

Build failed

@nikolaglumac nikolaglumac merged commit aab6ac4 into develop Dec 27, 2018
@iohk-bors iohk-bors bot deleted the feature/ddw-459-replace-in-app-support-request-with-links-to-support-page branch December 27, 2018 10:02
@nikolaglumac nikolaglumac mentioned this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants