Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-518, DDW-519, DDW-520, DDW-521] Improve NTP check handling on system wake-up event #1213

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Dec 6, 2018

This PR removes system time change detection logic which caused triggering of many forced NTP checks during system sleep. This logic has been replaced with legacy NTP force check 30-mins polling and thus resolved the original issue.

In the scope of this PR an issue with Cardano node state handling which caused problems on Windows where Daedalus would after waking up from sleep report that the state is unwnown has also been fix by preventing reset of Cardano node state on disconnect event in Network status store.


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac nikolaglumac changed the title [DDW-518] Improve NTP check handling on system wake-up event [DDW-518, DDW-519, DDW-520, DDW-521] Improve NTP check handling on system wake-up event Dec 8, 2018
@nikolaglumac nikolaglumac merged commit 84c180b into release/0.12.0 Dec 10, 2018
@nikolaglumac nikolaglumac deleted the fix/ddw-518-improve-ntp-check-handling-on-system-wake-up-event branch December 10, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants