-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-535] Support frontend only mode #1241
[DDW-535] Support frontend only mode #1241
Conversation
@cleverca22 thanks for the support, i fixed the This feature is now working for me - i can run Daedalus against a manually started @nikolaglumac @disassembler please test and spread the word to QA testers to give it a try too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikGuzei may I ask you to document this "frontend-only" mode in the main README file? 🙏
https://github.com/input-output-hk/daedalus into feature/ddw-535-support-manully-starting-cardano-node
This PR adds support for
frontendOnlyMode
which makes it possible to connect to manually started instances of cardano-node for advanced debugging purposes.How to Test:
nix-build -A connectScripts.testnet.wallet -o launch_testnet
./launch_testnet
state-wallet-testnet
folder inside the cardano-sl repo … copy the full path to the sub foldertls
in there.CARDANO_TLS_PATH=/path/to/tls CARDANO_HOST=localhost CARDANO_PORT=8090 nix-shell
Now you should have a pre-configured nix-shell session where you can
yarn dev
as usual and Daedalus connects itself to the manually started cardano node.Note:
Only
CARDANO_TLS_PATH
is mandatory.CARDANO_HOST
defaults tolocalhost
andCARDANO_PORT
to 8090 😉So if you just start the default cardano node (which runs on localhost:8090) you can also start nix-shell with
CARDANO_TLS_PATH=/path/to/tls nix-shell
Todos:
frontendOnlyMode
flag inlauncherConfig
is alwaystrue
… it should be false when--arg autoStartBackend true
is passed to the nix-shell command. This means that currently only the manual cardano node mode is working (since it's always assuming that it should run in frontend only mode!)nix-shell
(@cleverca22) - fixed in 045fc7aReview Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board