Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-746] Small UI and copy improvements #1459

Merged
merged 6 commits into from
Jul 11, 2019

Conversation

thedanheller
Copy link
Contributor

@thedanheller thedanheller commented Jul 10, 2019

This PR improves small UI and copy elements.

Todos

  • 'GPU safe mode' should be moved to the bottom of the menu, under 'Known issues' item.
  • 'GPU safe mode' should be renamed to 'Blank screen fix'. Copy in the dialog window should also be updated, both for turning on and off of this setting.
  • 'Help and support' should be renamed to 'Help' in the application menu
  • 'TLS certificate is not valid. Please restart Daedalus' message should be changed to 'A configuration issue was detected and fixed. Please restart Dedalus to continue.'.
  • Add the "Hide Daedalus", "Hide Others", and "Show All" menu options to the OSX menu.
  • Move 'Block consolidation status' and 'Daedalus diagnostics' under the help menu. Help menu should have these items in this order, including separators:
- Known Issues
- Blank Screen Fix
- ----------------
- Support Request
- Download Logs
- ----------------
- Block Consolidation Status
- Daedalus Diagnostics

Screenshots

English

Screenshot 2019-07-11 at 13 33 11

Screenshot 2019-07-11 at 13 33 32

Screenshot 2019-07-10 at 15 16 22

Screenshot 2019-07-11 at 15 39 08

Screenshot 2019-07-11 at 15 37 34

Japanese

Screenshot 2019-07-11 at 15 15 49

Screenshot 2019-07-11 at 15 15 54

Screenshot 2019-07-10 at 15 17 07

Screenshot 2019-07-11 at 15 39 37

Screenshot 2019-07-11 at 15 39 20


Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@nikolaglumac nikolaglumac self-assigned this Jul 11, 2019
@nikolaglumac nikolaglumac removed the WIP label Jul 11, 2019
@darko-mijic
Copy link
Contributor

Thanks for Japanese screenshots! ❤️

@nikolaglumac nikolaglumac merged commit 774b40f into develop Jul 11, 2019
@iohk-bors iohk-bors bot deleted the fix/ddw-746-small-ui-and-copy-improvements branch July 11, 2019 15:07
@darko-mijic darko-mijic mentioned this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants