Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-897] Rust node integration #1567

Merged
merged 17 commits into from
Sep 25, 2019
Merged

Conversation

Sam-Jeston
Copy link
Contributor

@Sam-Jeston Sam-Jeston commented Sep 13, 2019

This PR:

  • Changes the default Cardano node implementation to be Rust node to facilitate the incentivized testnet
  • Updates the V2 API importer to be Rust node style, not http-bridge
  • Adds the nodeImplementation and isIncentivizedTestnet to the relevent stores

My thoughts are that incentivized testnet features moving forward can be driven from

const { networkStatus } = stores
networkStatus.isIncentivizedTestnet

@tomothespian this branch has moved us to the Edge version (for the short term) of cardano-wallet. You might want to sanity check this branch to see if things that were working are broken. I expect this might be the case, but I'm not sure what state you had the branch in.

@cleverca22 I kept the config in the launcher.dhall after our conversation because it felt to me like each node should have a configuration file, and baking the value into the compiled JS wouldn't be ideal. I think this is a slightly more future proof approach as well. If we ever want to change out nodes implementation in realtime, then we will already expect to read and set the implementation from the LauncherConfig, instead of a single baked in ENV var

@Sam-Jeston Sam-Jeston self-assigned this Sep 13, 2019
@nikolaglumac nikolaglumac changed the title Jormungandr Integration Rust Node integration Sep 13, 2019
@nikolaglumac nikolaglumac changed the title Rust Node integration [DDW-897] Rust node integration Sep 13, 2019
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sam-Jeston nice work!
I see just one issue - it seems the API always returns all the wallets in "restoring" state :(
...this happens regardless of how you add a wallet - so it is the same for create/restoration/batch-import.

This didn't happen with the http-bridge. Any clue? Can you confirm this?

Screenshot 2019-09-17 at 11 32 50

Screenshot 2019-09-17 at 11 24 09

@Sam-Jeston
Copy link
Contributor Author

Ah yes I did see that @nikolaglumac, but wasn't sure if it was due to an unstable feature @tomothespian had worked on. Now that I know that it isn't, I will investigate

@nikolaglumac
Copy link
Contributor

Nope @Sam-Jeston - the v2-integration branch should be fully functional as far as the wallet handling is concerned.

@Sam-Jeston Sam-Jeston removed the WIP label Sep 20, 2019
@Sam-Jeston
Copy link
Contributor Author

@nikolaglumac this is resolved.

When we go to start Jormungandr, we check to see if a secret file exists in the state directory, as this is required to run the node. If it doesn't, we create it and create the block0.bin from a default testnet genesis.yml. This yml references the public key of the private key stored in the secret file, hence the string interpolation prior to writing the custom genesis.yml to disk.

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nikolaglumac nikolaglumac merged commit e8fb608 into v2-integration Sep 25, 2019
@iohk-bors iohk-bors bot deleted the jormungandr-integration branch September 25, 2019 08:46
@nikolaglumac nikolaglumac added release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check and removed V2-API ⏳release-vNext labels Nov 15, 2019
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants