-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-897] Rust node integration #1567
Conversation
* TODO: Properly arrange config
* TODO: Lift nodeImplementation to build config
…into jormungandr-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sam-Jeston nice work!
I see just one issue - it seems the API always returns all the wallets in "restoring" state :(
...this happens regardless of how you add a wallet - so it is the same for create/restoration/batch-import.
This didn't happen with the http-bridge. Any clue? Can you confirm this?
Ah yes I did see that @nikolaglumac, but wasn't sure if it was due to an unstable feature @tomothespian had worked on. Now that I know that it isn't, I will investigate |
Nope @Sam-Jeston - the |
@nikolaglumac this is resolved. When we go to start Jormungandr, we check to see if a secret file exists in the state directory, as this is required to run the node. If it doesn't, we create it and create the block0.bin from a default testnet genesis.yml. This yml references the public key of the private key stored in the secret file, hence the string interpolation prior to writing the custom genesis.yml to disk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR:
My thoughts are that incentivized testnet features moving forward can be driven from
@tomothespian this branch has moved us to the Edge version (for the short term) of
cardano-wallet
. You might want to sanity check this branch to see if things that were working are broken. I expect this might be the case, but I'm not sure what state you had the branch in.@cleverca22 I kept the config in the launcher.dhall after our conversation because it felt to me like each node should have a configuration file, and baking the value into the compiled JS wouldn't be ideal. I think this is a slightly more future proof approach as well. If we ever want to change out nodes implementation in realtime, then we will already expect to read and set the implementation from the LauncherConfig, instead of a single baked in ENV var