Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-899] Remove accounts #1614

Merged
merged 5 commits into from
Oct 22, 2019
Merged

[DDW-899] Remove accounts #1614

merged 5 commits into from
Oct 22, 2019

Conversation

tomislavhoracek
Copy link
Contributor

@tomislavhoracek tomislavhoracek commented Oct 22, 2019 •
edited
Loading

This PR removes all notions of account and account indexes from the codebase.

Testing Checklist

  • Slack QA thread
  • Check if transactions works properly
  • Check if addresses are listed properly

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@tomislavhoracek tomislavhoracek self-assigned this Oct 22, 2019
@tomislavhoracek tomislavhoracek requested review from nikolaglumac and a team October 22, 2019 10:48
@tomislavhoracek tomislavhoracek changed the title [DDW-899] Remove account [DDW-899] Remove accounts Oct 22, 2019
nikolaglumac
nikolaglumac suggested changes Oct 22, 2019
View reviewed changes
features/tests/e2e/steps/transactions-steps.js Outdated
@@ -28,18 +28,14 @@ Given(
new window.Promise(resolve =>
// Need to fetch the wallets data async and wait for all results
window.Promise.all([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomothespian I don't think we need Promise.all here anymore...

Copy link
Contributor Author

@tomislavhoracek tomislavhoracek Oct 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaglumac you are in right 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaglumac Done, can you re-check please?

nikolaglumac
nikolaglumac approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 💯

@nikolaglumac nikolaglumac merged commit bd58559 into v2-integration Oct 22, 2019
@iohk-bors iohk-bors bot deleted the chore/ddw-899-remove-accounts branch October 22, 2019 13:34
@nikolaglumac nikolaglumac added release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check and removed V2-API ⏳release-vNext labels Nov 15, 2019
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolaglumac nikolaglumac nikolaglumac approved these changes

Assignees

@tomislavhoracek tomislavhoracek

Labels
chore release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomislavhoracek @nikolaglumac