-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-895] Spending password should be always required #1631
[DDW-895] Spending password should be always required #1631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@IuliaDolishniak password filed validation on Japanese is an old problem as I think. I didn't touch that. |
This issue is a known one which we will handle later on. Here's a design solution for it: https://iohk.myjetbrains.com/youtrack/issue/DDW-638 @IuliaDolishniak please approve the PR if this was the only thing you have found. |
@daniloprates please review this one 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomothespian great work! 🧐😎💯
This PR introduces a "Spending password" as a required parameter.
Screenshots
1. Create Wallet
2. Restore Wallet
3. Change Wallet Password
Testing Checklist
AddWallet -> WalletCreateDialog - old
AddWallet -> WalletRestoreDialog
WalletScreens -> Settings
(selectChange Password
knob and checkChange Password - Show Dialog
)Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board