Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-895] Spending password should be always required #1631

Merged

Conversation

tomislavhoracek
Copy link
Contributor

@tomislavhoracek tomislavhoracek commented Oct 31, 2019

This PR introduces a "Spending password" as a required parameter.

Screenshots

1. Create Wallet

EN - Create Wallet
JA - Create Wallet

2. Restore Wallet

EN- Restore Wallet
JA- Restore Wallet

3. Change Wallet Password

EN- Change Wallet Password
JA - Change Wallet Password


Testing Checklist

  • Slack QA thread
  • Create Wallet dialog (password is always required and switch is not presented) - Test storybook story under: AddWallet -> WalletCreateDialog - old
  • Restore Wallet dialog (password is always required and switch is not presented) - Test storybook story under: AddWallet -> WalletRestoreDialog
  • Create Wallet dialog (password is always required and switch is not presented) - Test storybook story under: WalletScreens -> Settings (select Change Password knob and check Change Password - Show Dialog)

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IuliaDolishniak
Copy link

IuliaDolishniak commented Oct 31, 2019

screen
Not properly aligned in Japanese and also the hyphenation doesnt look good for create and restore wallet dialogs

@IuliaDolishniak
Copy link

screen
same here

@tomislavhoracek
Copy link
Contributor Author

tomislavhoracek commented Oct 31, 2019

@IuliaDolishniak password filed validation on Japanese is an old problem as I think. I didn't touch that.
@nikolaglumac Shall we change that or that should be in the scope of some other task?

@nikolaglumac
Copy link
Contributor

This issue is a known one which we will handle later on. Here's a design solution for it: https://iohk.myjetbrains.com/youtrack/issue/DDW-638

@IuliaDolishniak please approve the PR if this was the only thing you have found.

@nikolaglumac
Copy link
Contributor

@daniloprates please review this one 🙏

Copy link
Contributor

@thedanheller thedanheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomothespian great work! 🧐😎💯

@nikolaglumac nikolaglumac merged commit 433457a into v2-integration Nov 1, 2019
@iohk-bors iohk-bors bot deleted the feature/ddw-895-spending-password-always-required branch November 1, 2019 19:44
@nikolaglumac nikolaglumac added release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check and removed V2-API ⏳release-vNext labels Nov 15, 2019
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants