-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1000] Integrate legacy wallet transactions list V2 API endpoint #1641
[DDW-1000] Integrate legacy wallet transactions list V2 API endpoint #1641
Conversation
…d-testnet improvement
…wallet-transactions-list-v2-api-endpoint
…ist-v2-api-endpoint' of github.com:input-output-hk/daedalus into feature/ddw-1000-integrate-legacy-wallet-transactions-list-v2-api-endpoint
… input addresses and NO addressess
@daniloprates please review this one 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
…wallet-transactions-list-v2-api-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomothespian code changes look good and everything works good.
Please check the comments from @gnpf AND make sure the fonts are correctly rendered.
This is very important as the row heights have to be exactly the same since we have that virtual list rendering here. If you look more closely when toggling expanded/collapsed transaction state you can see that there is some hickups with the rendering of the expanded transaction size - as if it first renders with height X and then in the next second decreases in size to X-10px or so.
We can have a call about this tomorrow...
…wallet-transactions-list-v2-api-endpoint
…wallet-transactions-list-v2-api-endpoint
@gnpf this is how is defined in designs: |
…ist-v2-api-endpoint' of github.com:input-output-hk/daedalus into feature/ddw-1000-integrate-legacy-wallet-transactions-list-v2-api-endpoint
my bad... sorry |
@nikolaglumac I'm not sure that I can reproduce that, I mean, I tried. It would be great if you can show me on call |
https://zpl.io/adl6D1a - updated this screen |
@gnpf this one is done |
@gnpf @a-rukin styles updated! Can you please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look good, nice job 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR introduces the Legacy Wallet transactions list API V2 endpoint.
Todos
Screenshots
No Addresses
Unresolved addresses
Testing Checklist
**NOTE: **
It is not possible to test Legacy wallet transactions because we don't have wallet with transactions
1. Test Storybook stories
WalletTransactionsList -> transactions with unresolved income addresses
WalletTransactionsList -> transactions without income addresses
2. In-App testing
Transactions without income addresses
Run
yarn v2-api-importer
to get wallets with fundsCheck transaction details on one off wallets and
From
address should be:No Addresses
Transactions with unresolved income addresses
Run
yarn v2-api-importer
to get wallets with fundsCreate
Test Wallet
Send ADA from one of imported wallets to
Test Wallet
Check
Test Wallet
transaction details andFrom
address should be:Open this transaction in Cardano explorer
link.Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board