-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1043] Disable/hide wallet recovery phrase verification feature #1645
[DDW-1043] Disable/hide wallet recovery phrase verification feature #1645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly nice work! The only problem is the notification red dot still shows up - you will have to disable it for the Incentivized Testnet 🙏
In order to "provoke" it you need to edit the ~/Library/Application\ Support/Daedalus/config.json
and edit the evelopment-WALLETS
key value and change the creationDate
of all the wallets to be more than 1 year old...
…-recovery-phrase-verification-feature # Conflicts: # CHANGELOG.md
…et-recovery-phrase-verification-feature' into chore/ddw-1043-disable/hide-wallet-recovery-phrase-verification-feature # Conflicts: # CHANGELOG.md
Fixed |
…-recovery-phrase-verification-feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-recovery-phrase-verification-feature
…-recovery-phrase-verification-feature
…et-recovery-phrase-verification-feature' into chore/ddw-1043-disable/hide-wallet-recovery-phrase-verification-feature
Fixed @nikolaglumac |
…-recovery-phrase-verification-feature
…fication-feature' of github.com:input-output-hk/daedalus into chore/ddw-1043-disable/hide-wallet-recovery-phrase-verification-feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @DeeJayElly 🎉
This PR hides wallet recovery phrase verification feature
YouTrack Ticket
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board