Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1043] Disable/hide wallet recovery phrase verification feature #1645

Conversation

DeeJayElly
Copy link
Contributor

@DeeJayElly DeeJayElly commented Nov 6, 2019

This PR hides wallet recovery phrase verification feature
YouTrack Ticket

Testing Checklist

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@nikolaglumac nikolaglumac self-requested a review November 6, 2019 22:35
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly nice work! The only problem is the notification red dot still shows up - you will have to disable it for the Incentivized Testnet 🙏
In order to "provoke" it you need to edit the ~/Library/Application\ Support/Daedalus/config.json and edit the evelopment-WALLETS key value and change the creationDate of all the wallets to be more than 1 year old...

Screenshot 2019-11-06 at 23 37 42

…-recovery-phrase-verification-feature

# Conflicts:
#	CHANGELOG.md
…et-recovery-phrase-verification-feature' into chore/ddw-1043-disable/hide-wallet-recovery-phrase-verification-feature

# Conflicts:
#	CHANGELOG.md
@DeeJayElly
Copy link
Contributor Author

@DeeJayElly nice work! The only problem is the notification red dot still shows up - you will have to disable it for the Incentivized Testnet 🙏
In order to "provoke" it you need to edit the ~/Library/Application\ Support/Daedalus/config.json and edit the evelopment-WALLETS key value and change the creationDate of all the wallets to be more than 1 year old...

Screenshot 2019-11-06 at 23 37 42

Fixed

@DeeJayElly DeeJayElly removed the WIP label Nov 7, 2019
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yakovkaravelov the notification dot in the More menu is no longer visible but the one in the wallet list is :(

Screenshot 2019-11-07 at 08 57 01

nikolaglumac and others added 4 commits November 7, 2019 09:55
…et-recovery-phrase-verification-feature' into chore/ddw-1043-disable/hide-wallet-recovery-phrase-verification-feature
@DeeJayElly DeeJayElly removed the WIP label Nov 7, 2019
@DeeJayElly
Copy link
Contributor Author

Fixed @nikolaglumac

…fication-feature' of github.com:input-output-hk/daedalus into chore/ddw-1043-disable/hide-wallet-recovery-phrase-verification-feature
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DeeJayElly 🎉

@nikolaglumac nikolaglumac merged commit d67a14a into v2-integration Nov 7, 2019
@iohk-bors iohk-bors bot deleted the chore/ddw-1043-disable/hide-wallet-recovery-phrase-verification-feature branch November 7, 2019 16:04
@nikolaglumac nikolaglumac added release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check and removed V2-API ⏳release-vNext labels Nov 15, 2019
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-1.0.0-ITN0 Daedalus Incentivized Testnet - Balance check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants