-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1100] Implement Yoroi wallets restoration #1740
[DDW-1100] Implement Yoroi wallets restoration #1740
Conversation
@DeeJayElly hi, these could be an expected issues but just wanted to make a note of it: |
Issue 1. should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly please add the requested changes and make sure to implement:
- Mocked Yoroi legacy wallet restoration endpoint in the API file: https://github.com/input-output-hk/daedalus/blob/v2-integration/source/renderer/app/api/api.js
- Store logic which would point to this new endpoint in case we are restoring a
Legacy
Yoroi wallet OR to the normal restoration if we are restoring aRegular
(Shelley/Rewards) Yoroi wallet.
Thanks!
Do not merge this PR before |
…lets-restoration # Conflicts: # CHANGELOG.md
…allets-restoration' into chore/ddw-1100-implement-yoroi-wallets-restoration # Conflicts: # CHANGELOG.md # nix/sources.json
…lets-restoration # Conflicts: # CHANGELOG.md
…7a15e80db56be7e6ca
This PR updates Restore Wallet dialog with Yoroi wallets restoration.
Screenshots
English
Japanese
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board