Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1100] Implement Yoroi wallets restoration #1740

Merged

Conversation

DeeJayElly
Copy link
Contributor

@DeeJayElly DeeJayElly commented Dec 5, 2019

This PR updates Restore Wallet dialog with Yoroi wallets restoration.

Screenshots

English

Screenshot 2019-12-11 17 31 26

Japanese

Screenshot 2019-12-11 17 32 01


Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@DeeJayElly DeeJayElly added chore ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Dec 5, 2019
@DeeJayElly DeeJayElly requested review from alexander-rukin and a team December 5, 2019 22:44
@DeeJayElly DeeJayElly self-assigned this Dec 5, 2019
@IuliaDolishniak
Copy link

@DeeJayElly hi, these could be an expected issues but just wanted to make a note of it:

  1. new label on your screen have a different color
  2. this is a known issue but still there - in Japanese version we have textboxes on a different height
    2019-12-06_07-40-03

@nikolaglumac
Copy link
Contributor

Issue 1. should be fixed.
Issue 2. is a known issue which we will not be fixing now.
cc @DeeJayElly @IuliaDolishniak

@nikolaglumac nikolaglumac added release-2.0.0-ITN1 Daedalus Incentivized Testnet - Rewards and removed ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Dec 6, 2019
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly please add the requested changes and make sure to implement:

Thanks!

source/renderer/app/i18n/locales/en-US.json Outdated Show resolved Hide resolved
source/renderer/app/config/walletsConfig.js Outdated Show resolved Hide resolved
source/renderer/app/config/walletsConfig.js Outdated Show resolved Hide resolved
@nikolaglumac nikolaglumac changed the title [DDW-1100] Implement yoroi wallets restoration [DDW-1100] Implement Yoroi wallets restoration Dec 6, 2019
@nikolaglumac nikolaglumac added feature and removed chore labels Dec 6, 2019
@thedanheller
Copy link
Contributor

Do not merge this PR before DDW-1156 is done.

@darko-mijic darko-mijic merged commit 11abc96 into v2-integration Dec 23, 2019
@iohk-bors iohk-bors bot deleted the chore/ddw-1100-implement-yoroi-wallets-restoration branch December 23, 2019 15:16
@darko-mijic darko-mijic mentioned this pull request Dec 23, 2019
36 tasks
@nikolaglumac nikolaglumac added release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards and removed ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards DO NOT MERGE labels Jan 22, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants