Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-982] Distinguish unit and e2e test setup #1743

Merged

Conversation

DominikGuzei
Copy link
Member

This speeds up the performance of unit tests because the ui isn’t booted up unnecesarily.


Testing Checklist

  • No QA testing required.
  • Devs: you can simply run yarn test to see the improved unit testing speed.

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@DominikGuzei DominikGuzei requested a review from a team December 6, 2019 10:51
@DominikGuzei DominikGuzei self-assigned this Dec 6, 2019
@DominikGuzei DominikGuzei changed the base branch from develop to v2-integration December 6, 2019 12:34
@nikolaglumac nikolaglumac added the release-2.0.0-ITN1 Daedalus Incentivized Testnet - Rewards label Dec 6, 2019
This speeds up the performance of unit tests
because the ui isn’t booted up unnecesarily
@DominikGuzei DominikGuzei force-pushed the chore/ddw-982-distinguish-unit-and-e2e-test-setup branch from 73b411e to 222d495 Compare December 6, 2019 14:59
@nikolaglumac
Copy link
Contributor

@DmitriiGaico no QA required for this one!

@nikolaglumac nikolaglumac self-requested a review December 6, 2019 15:15
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement @DominikGuzei 💯

@nikolaglumac nikolaglumac merged commit 5beb376 into v2-integration Dec 6, 2019
@iohk-bors iohk-bors bot deleted the chore/ddw-982-distinguish-unit-and-e2e-test-setup branch December 6, 2019 15:16
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-2.0.0-ITN1 Daedalus Incentivized Testnet - Rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants