-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1092] Make all notification UI/UX the same #1748
Merged
thedanheller
merged 41 commits into
v2-integration
from
feature/ddw-1092-make-all-notification-uiux-the-same
Dec 17, 2019
Merged
[DDW-1092] Make all notification UI/UX the same #1748
thedanheller
merged 41 commits into
v2-integration
from
feature/ddw-1092-make-all-notification-uiux-the-same
Dec 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaglumac
changed the title
[DDW-1092] Make all notification uiux the same
[DDW-1092] Make all notification UI/UX the same
Dec 10, 2019
nikolaglumac
added
⏳release-vNext-ITN1
Daedalus Incentivized Testnet - Rewards
feature
WIP
labels
Dec 10, 2019
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…f github.com:input-output-hk/daedalus into feature/ddw-1092-make-all-notification-uiux-the-same
…https://github.com/input-output-hk/daedalus into feature/ddw-1092-make-all-notification-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…tion-uiux-the-same
…https://github.com/input-output-hk/daedalus into feature/ddw-1092-make-all-notification-uiux-the-same
DeeJayElly
approved these changes
Dec 16, 2019
IuliaDolishniak
approved these changes
Dec 16, 2019
@daniloprates can you fix this too? or I should approve without it? |
DmitriiGaico
approved these changes
Dec 16, 2019
alexander-rukin
approved these changes
Dec 16, 2019
…tion-uiux-the-same
iohk-bors
bot
deleted the
feature/ddw-1092-make-all-notification-uiux-the-same
branch
December 17, 2019 01:49
36 tasks
This PR is missing Japanese screenshots which are always very helpful when writing release notes. |
@input-output-hk/daedalus can someone please add this missing screenshot? 🙏 |
@nikolaglumac I will add missing screenshots |
@nikolaglumac @darko-mijic PR screenshots updated! |
nikolaglumac
added
release-2.1.0-ITN1
Daedalus Incentivized Testnet - Rewards
and removed
⏳release-vNext-ITN1
Daedalus Incentivized Testnet - Rewards
labels
Jan 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements all notifications to be on the top of the app and in front of any other element. It also standardizes the notifications, as they were done differently through the app.
Screenshots
English:
Japanese:
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board