Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-996] Add more hotkeys to the Daedalus #1780

Merged

Conversation

thedanheller
Copy link
Contributor

@thedanheller thedanheller commented Dec 16, 2019

This PR implements new menu shortcuts:

  • Settings
  • Wallet settings

Todos

  • Add menu items with their translation
  • Add "go to page" functionality via IPC communication

Screenshots

image
image


Testing Checklist

  • Slack QA thread
  • The shortcuts will always be visible, but only work when possible. For instance, if there is no wallet selected, the "Wallet settings" item will do nothing. In case ITN is visible, the shortcuts will work on the background.

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@thedanheller thedanheller added feature WIP ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Dec 16, 2019
@thedanheller thedanheller self-assigned this Dec 16, 2019
@gabriela-ponce
Copy link

@daniloprates In Windows, the setting hotkeys reads Ctrl + Comma instead of Ctrl + ,

image

@thedanheller
Copy link
Contributor Author

@daniloprates In Windows, the setting hotkeys reads Ctrl + Comma instead of Ctrl + ,

@gnpf I wasn't happy where we were placing the items for the Windows menu, as it's a Mac standard. As a Windows user, I would expect to find Preferences/Settings under any menu item close to Help. Therefore I have moved them to View, and the shortcuts are Alt+S for Settings and Ctrl+Alt+S for Wallet Settings. Could you give it another go? Thanks

@thedanheller thedanheller removed the WIP label Dec 17, 2019
Copy link
Contributor

@DeeJayElly DeeJayElly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job @daniloprates

@thedanheller thedanheller merged commit 94d53a2 into v2-integration Dec 18, 2019
@iohk-bors iohk-bors bot deleted the feature/ddw-996-add-more-hotkeys-to-the-daedalus branch December 18, 2019 13:08
@darko-mijic darko-mijic mentioned this pull request Dec 23, 2019
36 tasks
@nikolaglumac nikolaglumac added the release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards label Jan 22, 2020
@nikolaglumac nikolaglumac removed the ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards label Jan 22, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants