-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1156] Implement Hardware wallets restoration #1801
Merged
darko-mijic
merged 104 commits into
v2-integration
from
feature/ddw-1156-implement-hardware-wallets-restoration
Jan 9, 2020
Merged
[DDW-1156] Implement Hardware wallets restoration #1801
darko-mijic
merged 104 commits into
v2-integration
from
feature/ddw-1156-implement-hardware-wallets-restoration
Jan 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/ddw-1156-implement-hardware-wallets-restoration
…e-wallets-restoration
…are-wallets-restoration' into feature/ddw-1156-implement-hardware-wallets-restoration
… Ledger, since Ledger Nano X and Nano S are supported & Removed isLedger and unneeded query parameters
…to remove code duplication
…ble because UI needs to be scrolled
…' of https://github.com/input-output-hk/daedalus into feature/ddw-1156-implement-hardware-wallets-restoration
…ed for selectors in e2e test and fix
…are-wallets-restoration' into feature/ddw-1156-implement-hardware-wallets-restoration
darko-mijic
reviewed
Jan 7, 2020
IuliaDolishniak
approved these changes
Jan 8, 2020
iohk-bors
bot
deleted the
feature/ddw-1156-implement-hardware-wallets-restoration
branch
January 9, 2020 06:14
nikolaglumac
added
release-2.1.0-ITN1
Daedalus Incentivized Testnet - Rewards
and removed
⏳release-vNext-ITN1
Daedalus Incentivized Testnet - Rewards
labels
Jan 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Restore Wallet dialog with Hardware wallets restoration.
Todos
f003b3139ff883fd5b6bb0566c4aa9786c838eca
with hw wallet support and recheck/fix integrationhttps://docs.google.com/document/d/17cWHcPvKLc0Dx2YDjaBHujX0UScEOLEKVhmrNgTz38c/edit
restoreByronRandomWallet
,restoreByronIcarsWallet
,restoreByronTrezorWallet
,restoreByronLedgerWallet
, under the hood these should call internal function for legacy restorationisLedger
and unneeded query parametersScreenshots
Testing Checklist
We can verify that we have implemented this functionality properly by checking which wallet IDs we get after restoration. This is already covered by e2e tests and IDs there should not be changed.
E2e test is needed for test case 3.
Slack QA thread
1. Restore Daedalus Balance wallet -
0.000010
ada["prison", "census", "discover", "give", "sound", "behave", "hundred", "cave", "someone", "orchard", "just", "wild"]
,and ID
legacy_6eb9a6862e5656b4a52fa6fae8eb3a3e8f7c2bd6
2. Restore Daedalus Rewards wallet - 0 ada
combine mouse cool skirt truck outer result speed fringe sugar there usage lucky wild tail
,and ID
c2ebd8b727cc760fe2f0fb3d06a8630ccc8c70f5
3. Invalid paper wallet mnemonic
worry pluck anchor recycle predict grow inner inside face face subway meat away once february family rug make hub violin riot around coast play pluck grow face
4. Valid paper wallet mnemonic - 0 ada
season nice police near blame dress deal congress unusual more giggle pull general list crash gravity fashion notable voice resemble auto smart flat party thought unique amused
legacy_699c20fef5469d2cabadf5a778932d06ca3364e2
5. Yoroi Balance wallet - 1,000,000.000000 ada
"defense", "brush", "fiscal", "cactus", "rotate", "trouble", "mean", "quantum", "shrug", "slight", "dignity", "corn", "immense", "first", "citizen"
legacy_aab5517861cca76a53d83e24c84542ecac6c0a3d
6. Yoroi Rewards wallet - 0 ada
"defense", "brush", "fiscal", "cactus", "rotate", "trouble", "mean", "quantum", "shrug", "slight", "dignity", "corn", "immense", "first", "citizen"
aab5517861cca76a53d83e24c84542ecac6c0a3d
7. Ledger Balance - 12 words
"struggle", "section", "scissors", "siren", "garbage", "yellow", "maximum", "finger", "duty", "require", "mule", "earn"
legacy_64c76f5644be19e5ba4cbe717967e2fd057079b3
8. Leger wallet - 18 words:
"vague" , "wrist" , "poet" , "crazy" , "danger" , "dinner", "grace" , "home" , "naive" , "unfold" , "april" , "exile", "relief" , "rifle" , "ranch" , "tone" , "betray" , "wrong"
9. Ledger walelt - 24 words:
"recall" , "grace" , "sport" , "punch" , "exhibit" , "mad", "harbor" , "stand" , "obey" , "short" , "width" , "stem", "awkward" , "used" , "stairs" , "wool" , "ugly" , "trap", "season" , "stove" , "worth" , "toward" , "congress" , "jaguar"
10. Trezor wallet - 12 words:
walk", "license", "firm", "dwarf", "hundred", "pride", "ensure", "midnight", "unit", "keen", "warfare", "east"
11. Trezor wallet - 18 words:
"hen", "idea", "mimic", "frog", "second", "magnet", "egg", "indicate", "jar", "girl", "broccoli", "heart", "verify", "person", "present", "toe", "vibrant", "unable"
12. Trezor wallet - 24. words:
"slot", "young", "shoot", "surround", "equal", "trouble", "rice", "update", "rare", "dinosaur", "drastic", "kitten", "mom", "actress", "salon", "abuse", "happy", "satisfy"
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board