Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1179]: Improve delete wallet text copy #1819

Merged

Conversation

topseniors
Copy link
Contributor

This PR improved delete wallet text copy
YouTrack Ticket

Todos

  • Improve delete wallet text copy

Screenshots

English

image
image

Japanese

image
image

Testing Checklist

App

  • Go to Wallet settings screen and check if text content of delete wallet panel is using improved text copy
  • Click on Delete wallet button and check if text content of modal is using improved text copy

Storybook

  • Go to Wallets => Settings => Wallet Settings story and check if text content of delete wallet panel is using improved text copy
  • Go to Wallets => Settings => Delete - Countdown story and check if text content of modal is using improved text copy

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@topseniors topseniors added chore ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Jan 17, 2020
@topseniors topseniors self-assigned this Jan 17, 2020
@nikolaglumac
Copy link
Contributor

@a-rukin please test this one 🙏

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@nikolaglumac nikolaglumac merged commit 24da2ba into v2-integration Jan 17, 2020
@iohk-bors iohk-bors bot deleted the feature/ddw-1179-improve-delete-wallet-text-copy branch January 17, 2020 12:14
@nikolaglumac nikolaglumac added release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards and removed ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Jan 22, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants