Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-1184] Implement stake pool saturation and desirability attributes #1826

Merged
merged 5 commits into from
Jan 21, 2020
Merged

[DDW-1184] Implement stake pool saturation and desirability attributes #1826

merged 5 commits into from
Jan 21, 2020

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Jan 21, 2020 •
edited
Loading

This PR adds stake pool saturation info on the "Stake pools" screen and within the stake pool tooltip.

Todos

  • Add saturation info to stake pool tiles on the "Stake pools" screen
  • Add saturation info to stake pool tooltip
  • Bump cardano-wallet version

Screenshots

Screenshot 2020-01-21 at 15 18 32

Screenshot 2020-01-21 at 15 18 38

Testing Checklist

  • Slack QA thread
  • Check the display of stake pools saturation on "Staking pools" screen (both on stake pool cards/tiles and within the tooltip)

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@nikolaglumac nikolaglumac self-assigned this Jan 21, 2020
@nikolaglumac nikolaglumac added ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards feature WIP and removed WIP labels Jan 21, 2020
@thedanheller thedanheller self-requested a review January 21, 2020 14:32
thedanheller
thedanheller reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@thedanheller thedanheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Got NaN when running with the generated wallets.

@thedanheller
Copy link
Contributor

Got NaN when running with the generated wallets.

After rebuilding it, the error's gone

@nikolaglumac
Copy link
Contributor Author

@daniloprates I added a fallback to zero: 451633c

tomislavhoracek
tomislavhoracek reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaglumac "Saturation" is visible in the delegation wizard while the stake pool is selected. Can you please take a look
Screen Shot 2020-01-21 at 15 46 32

@tomislavhoracek
Copy link
Contributor

@nikolaglumac I don't see that stake pools are ranked / ordered by their desirability. Did I miss something?

@nikolaglumac
Copy link
Contributor Author

@nikolaglumac "Saturation" is visible in the delegation wizard while the stake pool is selected. Can you please take a look
Screen Shot 2020-01-21 at 15 46 32

Will check @tomothespian

@nikolaglumac
Copy link
Contributor Author

@nikolaglumac I don't see that stake pools are ranked / ordered by their desirability. Did I miss something?

Sorting is applied on the Api level @tomothespian

@tomislavhoracek
Copy link
Contributor

@nikolaglumac I don't see that stake pools are ranked / ordered by their desirability. Did I miss something?

Sorting is applied on the Api level @tomothespian

Aha aha ok @nikolaglumac
Then just "Saturation" while stake pool is selected. Rest is amazing 🚀

thedanheller
thedanheller approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@thedanheller thedanheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[██████████] 💯%

@nikolaglumac
Copy link
Contributor Author

@nikolaglumac "Saturation" is visible in the delegation wizard while the stake pool is selected. Can you please take a look
Screen Shot 2020-01-21 at 15 46 32

@tomothespian fixed:

Screenshot 2020-01-21 at 17 26 36

@nikolaglumac nikolaglumac mentioned this pull request Jan 21, 2020
Closed
30 tasks
tomislavhoracek
tomislavhoracek approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Amazing @nikolaglumac 💯 🚀

@nikolaglumac nikolaglumac merged commit c6059c5 into v2-integration Jan 21, 2020
@iohk-bors iohk-bors bot deleted the feature/ddw-1184-implement-stake-pool-saturation-and-desirability-attributes branch January 21, 2020 16:44
@nikolaglumac nikolaglumac added release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards and removed ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Jan 22, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaDolishniak IuliaDolishniak IuliaDolishniak approved these changes

@DmitriiGaico DmitriiGaico DmitriiGaico approved these changes

@tomislavhoracek tomislavhoracek tomislavhoracek approved these changes

@topseniors topseniors topseniors approved these changes

@alexander-rukin alexander-rukin alexander-rukin approved these changes

@thedanheller thedanheller thedanheller approved these changes

@gabriela-ponce gabriela-ponce Awaiting requested review from gabriela-ponce

Assignees

@nikolaglumac nikolaglumac

Labels
feature release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nikolaglumac @thedanheller @tomislavhoracek @alexander-rukin @topseniors @DmitriiGaico @IuliaDolishniak