[DDW-1186] Stake pool descriptions is not fully shown if it is long enough #1832

DeeJayElly · 2020-01-30T19:45:38Z

This PR fixes stake pool descriptions in not fully shown if it's long enough.

Ticket: https://iohk.myjetbrains.com/youtrack/issue/DDW-1186

Screenshots

Testing Checklist

Slack QA thread

Review Checklist

Basics

Code Quality

Important parts of the code are properly commented and documented
Code is properly typed with flow
React components are split-up enough to avoid unnecessary re-renderings
Any code that only works in main process is neatly separated from components

Testing

New feature/change is covered by acceptance tests
New feature/change is manually tested and approved by QA team
All existing acceptance tests are still up-to-date
New feature/change is covered by Daedalus Testing scenario
All existing Daedalus Testing scenarios are still up-to-date

After Review

Merge the PR
Delete the source branch
Move the ticket to done column on the YouTrack board
Update Slack QA thread by marking it with a green checkmark

… enough

MarcusHurney

Looks good! 👍

alexander-rukin · 2020-01-31T08:37:09Z

I assume that it would not fit the minumum screen size 🤔 @nikolaglumac shouldn't we show only first few lines here?

IuliaDolishniak · 2020-01-31T09:00:46Z

this way it looks for Delegation wizard in minimized mode
I know it is not directly by the PR but I think it should be fixed

DeeJayElly · 2020-01-31T09:05:31Z

I assume that it would not fit the minumum screen size 🤔 @nikolaglumac shouldn't we show only first few lines here?

I can add ellipsis and limit the height of the description text.

DeeJayElly · 2020-01-31T09:10:05Z

this way it looks for Delegation wizard in minimized mode
I know it is not directly by the PR but I think it should be fixed

Will recheck @IuliaDolishniak , thats a good catch and definitely it should be fixed

alexander-rukin · 2020-01-31T09:13:08Z

I assume that it would not fit the minumum screen size 🤔 @nikolaglumac shouldn't we show only first few lines here?

I can add ellipsis and limit the height of the description text.

https://zpl.io/a8p7ePJ - here is my proposal

thedanheller · 2020-01-31T10:26:20Z

https://zpl.io/a8p7ePJ - here is my proposal

@a-rukin
A tooltip over a tooltip looks confusing, to me. I'd try either expanding the text over the other information when hovering or having "Show more"/"Show less" links.

alexander-rukin · 2020-01-31T11:50:27Z

https://zpl.io/a8p7ePJ - here is my proposal

@a-rukin
A tooltip over a tooltip looks confusing, to me. I'd try either expanding the text over the other information when hovering or having "Show more"/"Show less" links.

links requite to click, this feature is ok to be hidden, as we can afford this

it's tooltip over popup dialog, so quite ok because first requires to click, second - to hover.
In the delegation dialog it's a bit awkward - yes.

As an option instead of "..." we can make gradient fadeout

DeeJayElly · 2020-01-31T11:54:44Z

https://zpl.io/a8p7ePJ - here is my proposal

@a-rukin
A tooltip over a tooltip looks confusing, to me. I'd try either expanding the text over the other information when hovering or having "Show more"/"Show less" links.

it's tooltip over popup dialog, so quite ok because first requires to click, second - to hover.
In the delegation dialog it's a bit awkward - yes.

As an option instead of "..." we can make gradient fadeout

Yeah i understand what you are trying to say. But our component currently we use "pop" as you say, as a tooltip component and for us that's already a popup. That's why @daniloprates said it's strange to see tooltip on top of tooltip.

alexander-rukin · 2020-01-31T11:56:50Z

Popup over popup is still ok.
Ex. dropdown menu with multi-levels (if implemented properly)

alexander-rukin · 2020-01-31T11:57:35Z

Other way around is to create stakepool page. Not sure you are ready to implement it now :D

… enough

…ns-is-not-fully-shown-if-it-is-long-enough

nikolaglumac · 2020-02-03T10:53:05Z

@DeeJayElly @a-rukin @darko-mijic let's have a call regarding this one today!

thedanheller · 2020-02-03T12:28:31Z

@DeeJayElly @a-rukin @darko-mijic let's have a call regarding this one today!

@nikolaglumac I'd like to participate as well if it didn't happen yet.

DeeJayElly · 2020-02-03T12:45:32Z

@DeeJayElly @a-rukin @darko-mijic let's have a call regarding this one today!

@nikolaglumac I'd like to participate as well if it didn't happen yet.

Let me know what timeframe? We can talk now or you want to go through it on our weekly call?

thedanheller · 2020-02-03T12:49:36Z

My suggestion: go for @a-rukin's proposal and think of a better overall solution. I have an idea that could integrate this issue with the Stake Pools comparison screen.

…ns-is-not-fully-shown-if-it-is-long-enough # Conflicts: # CHANGELOG.md

IuliaDolishniak · 2020-02-03T19:33:13Z

@nikolaglumac no, I am talking regarding this one (cutoff tooltip), I didnt know the reslution on it.

nikolaglumac · 2020-02-03T19:34:06Z

@IuliaDolishniak yes I am talking about the same one. Is that the only issue we have?

IuliaDolishniak · 2020-02-03T19:35:50Z

@nikolaglumac from my side - yes.

nikolaglumac · 2020-02-03T19:36:42Z

Ok. We will discuss what to do with that one tomorrow.

@DmitriiGaico are there any other issues you are aware of?

DmitriiGaico · 2020-02-03T21:21:17Z

Ok. We will discuss what to do with that one tomorrow.

@DmitriiGaico are there any other issues you are aware of?

In general the PR looks good. But no approval yet, please don't ask how i found this.

CLSD Pool Production.

Same Pool for the PR's Build. Looks like something is wrong.

…ns-is-not-fully-shown-if-it-is-long-enough

nikolaglumac · 2020-02-04T13:17:54Z

@DeeJayElly please update this line of the code: https://github.com/input-output-hk/daedalus/blob/v2-integration/source/main/config.js#L75 and increase the MIN_WINDOW_CONTENT_HEIGHT to 700. That will fix the tooltip clipping issues.

Please also remember to update these min-heights in storybook: https://github.com/input-output-hk/daedalus/blob/v2-integration/storybook/stories/_support/config.js#L44-L48 🙏

@IuliaDolishniak this will resolve the last remaining issue you have reported ☝️

nikolaglumac · 2020-02-04T14:42:10Z

@DeeJayElly please don't forget to check this one too: #1832 (comment)
Thanks!
cc @DmitriiGaico

…ns-is-not-fully-shown-if-it-is-long-enough

… enough - fixes min window height

…ions-is-not-fully-shown-if-it-is-long-enough' into fix/ddw-1186-stake-pool-descriptions-is-not-fully-shown-if-it-is-long-enough

DeeJayElly · 2020-02-05T09:54:24Z

Ok. We will discuss what to do with that one tomorrow.
@DmitriiGaico are there any other issues you are aware of?

In general the PR looks good. But no approval yet, please don't ask how i found this.

CLSD Pool Production.

Same Pool for the PR's Build. Looks like something is wrong.

@DmitriiGaico can you somehow show me how did you managed to reproduce this issue?

DmitriiGaico · 2020-02-05T09:57:52Z

@DeeJayElly Sure, i just installed latest Rewards Build. For that moment it was 10535 and opened CLSD Pool. So no Data Injection or any other Manipulations.

… enough - stake pool tooltip long words breaking

nikolaglumac

@DeeJayElly I have left you a couple of comments...

nikolaglumac · 2020-02-05T13:37:26Z

storybook/stories/_support/config.js

@@ -44,7 +44,7 @@ export const osNames: Array<any> = Object.keys(operatingSystems);
 export const osMinWindowHeights = {
  Windows: '541px',


@DeeJayElly you forgot to update the min-heights for Windows an Linux...

source/renderer/app/components/staking/stake-pools/StakePoolTooltip.scss

… enough - fixes

…ions-is-not-fully-shown-if-it-is-long-enough' into fix/ddw-1186-stake-pool-descriptions-is-not-fully-shown-if-it-is-long-enough

nikolaglumac

Great work @DeeJayElly 💅

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

c9b6f84

… enough

DeeJayElly added bug ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Jan 30, 2020

DeeJayElly requested review from alexander-rukin and a team January 30, 2020 19:45

DeeJayElly self-assigned this Jan 30, 2020

DeeJayElly changed the base branch from develop to v2-integration January 30, 2020 19:45

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

129bd04

… enough

MarcusHurney approved these changes Jan 31, 2020

View reviewed changes

DmitriiGaico requested review from ManusMcCole and IuliaDolishniak January 31, 2020 08:19

DeeJayElly and others added 4 commits February 1, 2020 12:26

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

1b12503

… enough

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

47116ec

… enough

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

b93f6aa

… enough

Merge branch 'v2-integration' into fix/ddw-1186-stake-pool-descriptio…

10f43ba

…ns-is-not-fully-shown-if-it-is-long-enough

Merge branch 'v2-integration' into fix/ddw-1186-stake-pool-descriptio…

d8ac39f

…ns-is-not-fully-shown-if-it-is-long-enough # Conflicts: # CHANGELOG.md

Merge branch 'v2-integration' into fix/ddw-1186-stake-pool-descriptio…

3cc20e9

…ns-is-not-fully-shown-if-it-is-long-enough

nikolaglumac added the WIP label Feb 4, 2020

DeeJayElly added 3 commits February 5, 2020 09:21

Merge branch 'v2-integration' into fix/ddw-1186-stake-pool-descriptio…

120a79e

…ns-is-not-fully-shown-if-it-is-long-enough

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

3652bc1

… enough - fixes min window height

Merge remote-tracking branch 'origin/fix/ddw-1186-stake-pool-descript…

9237a80

…ions-is-not-fully-shown-if-it-is-long-enough' into fix/ddw-1186-stake-pool-descriptions-is-not-fully-shown-if-it-is-long-enough

DeeJayElly and others added 2 commits February 5, 2020 13:05

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

c91d499

… enough - stake pool tooltip long words breaking

[DDW-1186] Improves CHANGELOG

7f0b9f6

nikolaglumac removed the WIP label Feb 5, 2020

nikolaglumac suggested changes Feb 5, 2020

View reviewed changes

nikolaglumac added the WIP label Feb 5, 2020

DmitriiGaico approved these changes Feb 5, 2020

View reviewed changes

DeeJayElly added 2 commits February 5, 2020 14:49

[DDW-1186] - Stake pool descriptions is not fully shown if it is long…

a238478

… enough - fixes

Merge remote-tracking branch 'origin/fix/ddw-1186-stake-pool-descript…

765688b

…ions-is-not-fully-shown-if-it-is-long-enough' into fix/ddw-1186-stake-pool-descriptions-is-not-fully-shown-if-it-is-long-enough

DmitriiGaico approved these changes Feb 5, 2020

View reviewed changes

nikolaglumac removed the WIP label Feb 5, 2020

nikolaglumac approved these changes Feb 5, 2020

View reviewed changes

nikolaglumac merged commit 4c5b40c into v2-integration Feb 5, 2020

iohk-bors bot deleted the fix/ddw-1186-stake-pool-descriptions-is-not-fully-shown-if-it-is-long-enough branch February 5, 2020 13:57

nikolaglumac added release-2.1.0-ITN1 Daedalus Incentivized Testnet - Rewards and removed ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Feb 18, 2020

nikolaglumac mentioned this pull request Apr 23, 2020

Release/1.0.0 #1995

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DDW-1186] Stake pool descriptions is not fully shown if it is long enough #1832

[DDW-1186] Stake pool descriptions is not fully shown if it is long enough #1832

DeeJayElly commented Jan 30, 2020 •

edited

Loading

MarcusHurney left a comment

alexander-rukin commented Jan 31, 2020

IuliaDolishniak commented Jan 31, 2020

DeeJayElly commented Jan 31, 2020

DeeJayElly commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020

thedanheller commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020 •

edited

Loading

DeeJayElly commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020

nikolaglumac commented Feb 3, 2020

thedanheller commented Feb 3, 2020

DeeJayElly commented Feb 3, 2020

thedanheller commented Feb 3, 2020

IuliaDolishniak commented Feb 3, 2020

nikolaglumac commented Feb 3, 2020

IuliaDolishniak commented Feb 3, 2020

nikolaglumac commented Feb 3, 2020

DmitriiGaico commented Feb 3, 2020 •

edited

Loading

nikolaglumac commented Feb 4, 2020

nikolaglumac commented Feb 4, 2020

DeeJayElly commented Feb 5, 2020

DmitriiGaico commented Feb 5, 2020

nikolaglumac left a comment

nikolaglumac Feb 5, 2020

DeeJayElly Feb 5, 2020

nikolaglumac left a comment

		@@ -44,7 +44,7 @@ export const osNames: Array<any> = Object.keys(operatingSystems);
		export const osMinWindowHeights = {
		Windows: '541px',

[DDW-1186] Stake pool descriptions is not fully shown if it is long enough #1832

[DDW-1186] Stake pool descriptions is not fully shown if it is long enough #1832

Conversation

DeeJayElly commented Jan 30, 2020 • edited Loading

Screenshots

Testing Checklist

Review Checklist

Basics

Code Quality

Testing

After Review

MarcusHurney left a comment

Choose a reason for hiding this comment

alexander-rukin commented Jan 31, 2020

IuliaDolishniak commented Jan 31, 2020

DeeJayElly commented Jan 31, 2020

DeeJayElly commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020

thedanheller commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020 • edited Loading

DeeJayElly commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020

alexander-rukin commented Jan 31, 2020

nikolaglumac commented Feb 3, 2020

thedanheller commented Feb 3, 2020

DeeJayElly commented Feb 3, 2020

thedanheller commented Feb 3, 2020

IuliaDolishniak commented Feb 3, 2020

nikolaglumac commented Feb 3, 2020

IuliaDolishniak commented Feb 3, 2020

nikolaglumac commented Feb 3, 2020

DmitriiGaico commented Feb 3, 2020 • edited Loading

nikolaglumac commented Feb 4, 2020

nikolaglumac commented Feb 4, 2020

DeeJayElly commented Feb 5, 2020

DmitriiGaico commented Feb 5, 2020

nikolaglumac left a comment

Choose a reason for hiding this comment

nikolaglumac Feb 5, 2020

Choose a reason for hiding this comment

DeeJayElly Feb 5, 2020

Choose a reason for hiding this comment

nikolaglumac left a comment

Choose a reason for hiding this comment

DeeJayElly commented Jan 30, 2020 •

edited

Loading

alexander-rukin commented Jan 31, 2020 •

edited

Loading

DmitriiGaico commented Feb 3, 2020 •

edited

Loading