Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1218] Update cardano-wallet revision #1870

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Feb 27, 2020

This PR updates cardano-wallet to the tip of the latest master branch: 3dcfee19e351e269302513eba4b5414f93ebe673 which introduces breaking API changes and uses Jormungandr 0.8.13.

Todos

  • DELETE /stake-pools/{poolId}/wallets/{walletId} becomes DELETE /stake-pools/*/wallets/{walletId}
  • GET /wallets/{walletId}/delegations/fees becomes GET /wallets/{walletId}/delegation-fees
  • GET /wallets/{walletId}/transactions/fees becomes GET /wallets/{walletId}/payment-fees
  • POST /byron-wallets/{style} becomes POST /byron-wallets and the style is moved to the request body (e.g. { ..., "style": "byron" })

Testing Checklist

  • Slack QA thread
  • Test stake pool delegation/redelegation
  • Test stake pool undelegation
  • Test creating transactions
  • Test byron/balance wallet restoration

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikolaglumac Amazing! 🎉

@cleverca22 cleverca22 force-pushed the chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes branch 2 times, most recently from 4e7a395 to 402991c Compare February 27, 2020 17:55
@nikolaglumac
Copy link
Contributor Author

@cleverca22 it seems that we are still facing issues with Windows selfnode build :(
All others are fixed and working nicely! Can you help us out please? 🙏

@nikolaglumac nikolaglumac removed the WIP label Mar 2, 2020
@disassembler disassembler force-pushed the chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes branch from 38e3fab to ebf60de Compare March 3, 2020 14:35
@cleverca22 cleverca22 force-pushed the chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes branch 7 times, most recently from 81c9563 to 3205231 Compare March 4, 2020 19:47
@cleverca22 cleverca22 force-pushed the chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes branch from 3205231 to a749b60 Compare March 4, 2020 19:48
@cleverca22 cleverca22 force-pushed the chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes branch from a749b60 to fff2f3f Compare March 4, 2020 19:49
@nikolaglumac nikolaglumac merged commit cde221a into v2-integration Mar 5, 2020
@iohk-bors iohk-bors bot deleted the chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes branch March 5, 2020 12:19
@nikolaglumac nikolaglumac added release-2.3.0-ITN1 Daedalus Incentivized Testnet - Rewards and removed ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Mar 10, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-2.3.0-ITN1 Daedalus Incentivized Testnet - Rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants