-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1218] Update cardano-wallet revision #1870
Merged
nikolaglumac
merged 6 commits into
v2-integration
from
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
Mar 5, 2020
Merged
[DDW-1218] Update cardano-wallet revision #1870
nikolaglumac
merged 6 commits into
v2-integration
from
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
Mar 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaglumac
added
chore
⏳release-vNext-ITN1
Daedalus Incentivized Testnet - Rewards
labels
Feb 27, 2020
nikolaglumac
requested review from
tomislavhoracek,
topseniors,
thedanheller,
DmitriiGaico,
gabriela-ponce,
IuliaDolishniak and
ManusMcCole
February 27, 2020 13:02
tomislavhoracek
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolaglumac Amazing! 🎉
cleverca22
force-pushed
the
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
branch
2 times, most recently
from
February 27, 2020 17:55
4e7a395
to
402991c
Compare
@cleverca22 it seems that we are still facing issues with Windows selfnode build :( |
disassembler
force-pushed
the
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
branch
from
March 3, 2020 14:35
38e3fab
to
ebf60de
Compare
cleverca22
force-pushed
the
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
branch
7 times, most recently
from
March 4, 2020 19:47
81c9563
to
3205231
Compare
cleverca22
force-pushed
the
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
branch
from
March 4, 2020 19:48
3205231
to
a749b60
Compare
cleverca22
force-pushed
the
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
branch
from
March 4, 2020 19:49
a749b60
to
fff2f3f
Compare
DmitriiGaico
approved these changes
Mar 5, 2020
iohk-bors
bot
deleted the
chore/ddw-1218-update-to-latest-cardano-wallet-and-handle-breaking-api-changes
branch
March 5, 2020 12:19
nikolaglumac
added
release-2.3.0-ITN1
Daedalus Incentivized Testnet - Rewards
and removed
⏳release-vNext-ITN1
Daedalus Incentivized Testnet - Rewards
labels
Mar 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
cardano-wallet
to the tip of the latest master branch:3dcfee19e351e269302513eba4b5414f93ebe673
which introduces breaking API changes and uses Jormungandr0.8.13
.Todos
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board