Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-769] Remove locale-specific rules from the CSS files #1871

Merged
merged 23 commits into from
Mar 10, 2020
Merged

[DDW-769] Remove locale-specific rules from the CSS files #1871

merged 23 commits into from
Mar 10, 2020

Conversation

DeeJayElly
Copy link
Contributor

@DeeJayElly DeeJayElly commented Feb 27, 2020 •
edited
Loading

This PR removes locale-specific rules from the CSS files.

Screenshots

ezgif com-video-to-gif

Testing Checklist

  • Slack QA thread
  • Test on Daedalus Diagnostics length between 'state directory' label and path is not overlapping other content OR breaking into multiple lines when changing Daedalus window size...

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@DeeJayElly DeeJayElly added bug ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Feb 27, 2020
@DeeJayElly DeeJayElly self-assigned this Feb 27, 2020
nikolaglumac
nikolaglumac suggested changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly there are still some edge cases where the UI falls apart:
Screenshot 2020-02-28 at 10 20 54

Can you try removing breakpoints and use flex-box instead?

@DeeJayElly
Copy link
Contributor Author

@DeeJayElly there are still some edge cases where the UI falls apart:
Screenshot 2020-02-28 at 10 20 54

Can you try removing breakpoints and use flex-box instead?

We need max-width in order to show the ellipsis (...) so i just tried to tweak it now.

nikolaglumac
nikolaglumac suggested changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly rejected! This is what I want: https://css-tricks.com/flexbox-truncated-text/

@nikolaglumac nikolaglumac changed the title [DDW-769] Remove locale specific rules from the css files [DDW-769] Remove locale-specific rules from the CSS files Feb 28, 2020
@nikolaglumac nikolaglumac self-assigned this Feb 28, 2020
topseniors
topseniors approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@topseniors topseniors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🎉

@DeeJayElly DeeJayElly removed the WIP label Mar 9, 2020
@DeeJayElly
Copy link
Contributor Author

@DeeJayElly the state dir line breaks in an awkward way in Japanese:
Screenshot 2020-03-09 at 13 41 36

Done

@nikolaglumac
Copy link
Contributor

Great @DeeJayElly 🎉

@a-rukin can you please check the spacing between the label and the "COPY" button? I believe it should be bigger than what it currently is... Please check and let @DeeJayElly know 🙏

spacing

@DmitriiGaico
Copy link

@DeeJayElly Hey! As discussed please double check Linux fonts.
image

topseniors
topseniors approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@topseniors topseniors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

nikolaglumac
nikolaglumac suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly can you please check the comments I have left?

source/renderer/app/components/status/DaedalusDiagnostics.scss Show resolved Hide resolved
source/renderer/app/components/status/DaedalusDiagnostics.scss Show resolved Hide resolved
source/renderer/app/components/status/DaedalusDiagnostics.scss Outdated Show resolved Hide resolved
@nikolaglumac
Copy link
Contributor

@DeeJayElly Hey! As discussed please double check Linux fonts.
image

@DmitriiGaico I don't think this font issue is related to this PR. Please test again - could be some glitch on your end. Compare v2-integration build too 🙏

cc @DeeJayElly

@alexander-rukin
Copy link
Contributor

Great @DeeJayElly 🎉

@a-rukin can you please check the spacing between the label and the "COPY" button? I believe it should be bigger than what it currently is... Please check and let @DeeJayElly know 🙏

spacing

@DeeJayElly can we make left padding to be at least 24px? so the button would be connected to the right part on any width.

tomislavhoracek
tomislavhoracek approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly Nice job 🚀

@DmitriiGaico
Copy link

@DeeJayElly Hello! looks like it was my local glitch. The fonts in the latest build looks same as in V2. Thank you!
cc @nikolaglumac

alexander-rukin
alexander-rukin approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexander-rukin alexander-rukin self-requested a review March 10, 2020 12:36
@DeeJayElly
[DDW-769] - Remove locale specific rules from the css files
e7c9d04
@DeeJayElly
Merge remote-tracking branch 'origin/fix/ddw-769-remove-locale-specif…
150aab4 
…ic-rules-from-the-css-files' into fix/ddw-769-remove-locale-specific-rules-from-the-css-files
@DeeJayElly
Copy link
Contributor Author

Great @DeeJayElly 🎉
@a-rukin can you please check the spacing between the label and the "COPY" button? I believe it should be bigger than what it currently is... Please check and let @DeeJayElly know 🙏
spacing

@DeeJayElly can we make left padding to be at least 24px? so the button would be connected to the right part on any width.

Done

@nikolaglumac nikolaglumac removed the WIP label Mar 10, 2020
@nikolaglumac nikolaglumac merged commit 0689eaf into v2-integration Mar 10, 2020
@iohk-bors iohk-bors bot deleted the fix/ddw-769-remove-locale-specific-rules-from-the-css-files branch March 10, 2020 18:42
@nikolaglumac nikolaglumac added ⏳release-vNext and removed ⏳release-vNext-ITN1 Daedalus Incentivized Testnet - Rewards labels Mar 20, 2020
@nikolaglumac nikolaglumac added release-1.0.0-FC1 Daedalus Flight and removed ⏳release-vNext labels Apr 1, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomislavhoracek tomislavhoracek tomislavhoracek approved these changes

@topseniors topseniors topseniors approved these changes

@nikolaglumac nikolaglumac nikolaglumac approved these changes

@alexander-rukin alexander-rukin Awaiting requested review from alexander-rukin

Assignees

@nikolaglumac nikolaglumac

@DeeJayElly DeeJayElly

Labels
bug release-1.0.0-FC1 Daedalus Flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DeeJayElly @nikolaglumac @DmitriiGaico @alexander-rukin @topseniors @tomislavhoracek