[DDW-80] Integrate network parameters api endpoint #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source/renderer/app/api/api.js
Outdated
| }; | ||
| } catch (error) { | ||
| logger.error('AdaApi::getNetworkParameters error', { error }); | ||
| // @API TODO - Inspect this implementation once TLS support is implemented on the BE |
There was a problem hiding this comment.
@yakovkaravelov please remove this todo as we don't need it for this endpoint.
| import { request } from '../../utils/request'; | ||
|
|
||
| export const getNetworkParameters = ( | ||
| epochId: string, |
There was a problem hiding this comment.
@yakovkaravelov epochId should be a number 🙏
| @@ -79,6 +82,43 @@ export default (api: AdaApi) => { | |||
| } | |||
| }; | |||
|
|
|||
| api.getNetworkParameters = async ( | |||
There was a problem hiding this comment.
@yakovkaravelov we don't need the patched Api method here. Please remove it.
| @@ -5,6 +5,7 @@ import { action } from 'mobx'; | |||
| import BigNumber from 'bignumber.js/bignumber'; | |||
| import AdaApi from '../api'; | |||
| import { getNetworkInfo } from '../network/requests/getNetworkInfo'; | |||
| import { getNetworkParameters } from '../network/requests/getNetworkParameters'; | |||
There was a problem hiding this comment.
@yakovkaravelov remove this unused import
| @@ -17,6 +18,8 @@ import StakePool from '../../domains/StakePool'; | |||
| import type { | |||
| GetNetworkInfoResponse, | |||
| NetworkInfoResponse, | |||
| GetNetworkParametersResponse, | |||
There was a problem hiding this comment.
@yakovkaravelov please remove these unused imports
iohk-bors
bot
deleted the
feature/ddw-80-integrate-network-parameters-api-endpoint
branch
disassembler
added a commit
that referenced
this pull request
Mar 27, 2020
…ub.com:input-output-hk/daedalus into chore/ddw-69-set-new-daedalus-name-and-version * 'chore/ddw-69-set-new-daedalus-name-and-version' of github.com:input-output-hk/daedalus: [DDW-69] Handle Flight network [DDW-39] Flight release information window (#1917) [DDW-80] Integrate network parameters api endpoint (#1915)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrated network parameters api endpoint.
Jira Ticket
Todos
Review Checklist
Basics
feature/bug/chore,release-x.x.x)yarn test)yarn dev)yarn package/ CI builds)yarn flow:test)yarn lint)yarn prettier:check)yarn manage:translationsproduces no changes)yarn storybook)yarn.lockfile is updatedCode Quality
Testing
After Review
donecolumn on the YouTrack board