Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDW-105] Force setting password on passwordless wallets #1957

Merged
merged 51 commits into from
Apr 15, 2020
Merged

[DDW-105] Force setting password on passwordless wallets #1957

merged 51 commits into from
Apr 15, 2020

Conversation

DeeJayElly
Copy link
Contributor

@DeeJayElly DeeJayElly commented Apr 7, 2020 •
edited by tomislavhoracek
Loading

This PR forces setting password on password less wallets by showing the dialog which informs the user that needs to set the password for his wallet.

Todos

  • Fix Storybook wallet context handling (@tomothespian)
  • Force creating wallet address on force-password-set action: DDW-125 (@tomothespian)

Screenshots

Screenshot 2020-04-09 09 13 04

Screenshot 2020-04-09 09 12 37

Testing Checklist

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@DeeJayElly DeeJayElly self-assigned this Apr 7, 2020
@DeeJayElly DeeJayElly changed the title Chore/ddw 105 force setting password on passwordless wallets [DDW-105] Force setting password on passwordless wallets Apr 7, 2020
nikolaglumac
nikolaglumac suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly this is not a good direction. Let's discuss this once you start today.
The implementation needs to be similar to this: https://github.com/input-output-hk/daedalus/blob/chore/ddw-105-force-setting-password-on-passwordless-wallets/source/renderer/app/components/wallet/not-responding/NotResponding.js

@DeeJayElly
Copy link
Contributor Author

@DeeJayElly I just checked locally and the background is not transparent on the theme "Incentivized Testnet"

image

Fixed

nikolaglumac
nikolaglumac suggested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly I have found two issues with storybook:

  1. The general context handling of wallets is wrong and when I change wallets on the "Wallet Summary" story I don't see the wallet balances getting updated nor does the "Set password" overlay gets shown for the wallets with no password set.

Screenshot 2020-04-14 at 09 22 08

  1. The "Set password" story shows the "Change wallet password" instead of "Set wallet password" dialog once you update the knob...

Screenshot 2020-04-14 at 09 21 57

nikolaglumac
nikolaglumac reviewed Apr 14, 2020
View reviewed changes
storybook/stories/_support/utils.js Outdated
@@ -44,7 +45,7 @@ export const generateWallet = (
reward: new BigNumber(reward).dividedBy(LOVELACES_PER_ADA),
createdAt: new Date(),
name,
hasPassword: false,
hasPassword: hasPassword || true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly this line will always make hasPassword to be true as even if you pass in hasPassword as false hasPassword || true will turn it to true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, its a leftover i forgot to revert back this part. Its fixed now.

@nikolaglumac
Copy link
Contributor

@DeeJayElly please fix the flow issue 🙏

@DeeJayElly
Copy link
Contributor Author

@DeeJayElly I have found two issues with storybook:

  1. The general context handling of wallets is wrong and when I change wallets on the "Wallet Summary" story I don't see the wallet balances getting updated nor does the "Set password" overlay gets shown for the wallets with no password set.
Screenshot 2020-04-14 at 09 22 08
  1. The "Set password" story shows the "Change wallet password" instead of "Set wallet password" dialog once you update the knob...
Screenshot 2020-04-14 at 09 21 57
  1. Fixed

@nikolaglumac
Copy link
Contributor

@DeeJayElly @daniloprates I have asked @tomothespian to fix the two remaining Todos:
Screenshot 2020-04-15 at 09 36 53

nikolaglumac
nikolaglumac approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now! Thanks @DeeJayElly @tomothespian <3

@nikolaglumac nikolaglumac merged commit 74c048d into develop Apr 15, 2020
@iohk-bors iohk-bors bot deleted the chore/ddw-105-force-setting-password-on-passwordless-wallets branch April 15, 2020 22:42
@nikolaglumac nikolaglumac added release-1.0.0-FC3 Daedalus Flight and removed ⏳release-vNext labels Apr 17, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriiGaico DmitriiGaico DmitriiGaico approved these changes

@gabriela-ponce gabriela-ponce gabriela-ponce approved these changes

@topseniors topseniors topseniors approved these changes

@alexander-rukin alexander-rukin alexander-rukin approved these changes

@nikolaglumac nikolaglumac nikolaglumac approved these changes

@DominikGuzei DominikGuzei Awaiting requested review from DominikGuzei

@thedanheller thedanheller Awaiting requested review from thedanheller

@tomislavhoracek tomislavhoracek Awaiting requested review from tomislavhoracek

Assignees

@DeeJayElly DeeJayElly

@tomislavhoracek tomislavhoracek

Labels
chore release-1.0.0-FC3 Daedalus Flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DeeJayElly @alexander-rukin @nikolaglumac @gabriela-ponce @topseniors @DmitriiGaico @tomislavhoracek