-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-846] Update react, react-router and other related dependencies #1966
[DDW-846] Update react, react-router and other related dependencies #1966
Conversation
…s' of github.com:input-output-hk/daedalus into chore/ddw-846-update-react-and-react-router-dependencies
…s' of github.com:input-output-hk/daedalus into chore/ddw-846-update-react-and-react-router-dependencies
@yakovkaravelov revert these changes: And run tests outside |
@nikolaglumac @tomothespian All test errors were fixed. Please review. |
…s' of github.com:input-output-hk/daedalus into chore/ddw-846-update-react-and-react-router-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 🎉
This PR updates
react
,react-router
,mobx
,mobx-react-router
, and their related package versionsJira Ticket
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board