Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-846] Update react, react-router and other related dependencies #1966

Merged

Conversation

topseniors
Copy link
Contributor

@topseniors topseniors commented Apr 17, 2020

This PR updates react, react-router, mobx, mobx-react-router, and their related package versions
Jira Ticket

Testing Checklist

  • Slack QA thread
  • Regression testing on all screens of app and stories of storybook

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@topseniors topseniors added the WIP label Apr 17, 2020
@topseniors topseniors self-assigned this Apr 17, 2020
@nikolaglumac nikolaglumac added ⏳release-vNext chore dependencies Pull requests that update a dependency file labels Apr 18, 2020
@nikolaglumac
Copy link
Contributor

@yakovkaravelov I also get failing tests on the ITN selfnode :(

Screenshot 2020-05-26 at 09 05 12

@tomislavhoracek
Copy link
Contributor

@topseniors
Copy link
Contributor Author

@nikolaglumac @tomothespian All test errors were fixed. Please review.
Thanks.

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉

@nikolaglumac nikolaglumac merged commit a7a65dc into develop Jun 4, 2020
@iohk-bors iohk-bors bot deleted the chore/ddw-846-update-react-and-react-router-dependencies branch June 4, 2020 13:01
@nikolaglumac nikolaglumac added release-1.0.0-STN1 Daedalus Shelley Testnet and removed ⏳release-vNext labels Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file release-1.0.0-STN1 Daedalus Shelley Testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants