Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-162, DDW-163] Fix 'Wallet import' UI/UX issues #1968

Merged
merged 5 commits into from
Apr 20, 2020

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Apr 17, 2020

This PR fixes:

  • Restores "learn more" link on the first "Wallet import" dialog
  • Updates open/save dialogs to use "Desktop" as default path for opening/saving files
  • Resets "Wallet import" dialog values on open
  • Fixes wallet rename success message flashing on "Wallet settings" screen
  • Fixes wallet screens scrollbar issue when active restoration notification is shown
  • Fixes "Wallet import" exception dialog locale

Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@DeeJayElly DeeJayElly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok @nikolaglumac

@ManusMcCole
Copy link

ManusMcCole commented Apr 17, 2020

On MacOS only there is an issue where the loading box flickers when a selected wallet import is loading. The box intermittently dissapears and reappears. Wallet import is succesfull it is just quite slow
LoadingBoxFlickering

@nikolaglumac
Copy link
Contributor Author

@ManusMcCole I don't see this issue on my mac. I believe this is due to the fact you were testing on a macOS VM.
@DeeJayElly @daniloprates @tomothespian please test this on your Mac's and let us know the results.

@DmitriiGaico @IuliaDolishniak @gnpf please check if you can reproduce this on Linux/Windows and please make sure to use real machines and not VMs.

@nikolaglumac nikolaglumac changed the title [DDW-162] Fix 'Wallet import' UI/UX issues [DDW-162, DDW-163] Fix 'Wallet import' UI/UX issues Apr 18, 2020
@nikolaglumac
Copy link
Contributor Author

@DmitriiGaico I have added a fix for https://jira.iohk.io/browse/DDW-163 into this PR. Please test that as too 🙏

@DmitriiGaico
Copy link

@nikolaglumac Disappearing button is showed for MacOS vms only. At Linux/Windows button works as expected.

@nikolaglumac
Copy link
Contributor Author

@gnpf @alan-mcnicholas can you confirm this bug on your macOS VM?

I would like to hear if any of the developers face the same issue on their real macs @tomothespian @DeeJayElly @yakovkaravelov @daniloprates 🙏

@darko-mijic
Copy link
Contributor

I can't reproduce this on a real Mac with the installer from this PR.

image

@ManusMcCole
Copy link

Gabriela also experienced this issue on her Mac VM on Friday

@nikolaglumac
Copy link
Contributor Author

OK. If this can only be produced on VMs then I am fine with ignoring this issue...

@darko-mijic
Copy link
Contributor

Completely agree @nikolaglumac. Merge away.

@darko-mijic darko-mijic self-requested a review April 20, 2020 09:05
@nikolaglumac nikolaglumac merged commit da9b64e into develop Apr 20, 2020
@iohk-bors iohk-bors bot deleted the fix/ddw-162-fix-wallet-import-uiux-issues branch April 20, 2020 12:27
@nikolaglumac nikolaglumac added release-1.0.0-FC5 Daedalus Flight and removed ⏳release-vNext labels Apr 21, 2020
@nikolaglumac nikolaglumac mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants