-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-162, DDW-163] Fix 'Wallet import' UI/UX issues #1968
[DDW-162, DDW-163] Fix 'Wallet import' UI/UX issues #1968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok @nikolaglumac
@ManusMcCole I don't see this issue on my mac. I believe this is due to the fact you were testing on a macOS VM. @DmitriiGaico @IuliaDolishniak @gnpf please check if you can reproduce this on Linux/Windows and please make sure to use real machines and not VMs. |
@DmitriiGaico I have added a fix for https://jira.iohk.io/browse/DDW-163 into this PR. Please test that as too 🙏 |
@nikolaglumac Disappearing button is showed for MacOS vms only. At Linux/Windows button works as expected. |
@gnpf @alan-mcnicholas can you confirm this bug on your macOS VM? I would like to hear if any of the developers face the same issue on their real macs @tomothespian @DeeJayElly @yakovkaravelov @daniloprates 🙏 |
Gabriela also experienced this issue on her Mac VM on Friday |
OK. If this can only be produced on VMs then I am fine with ignoring this issue... |
Completely agree @nikolaglumac. Merge away. |
This PR fixes:
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board