-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-131] Connecting a hardware wallet #2016
[DDW-131] Connecting a hardware wallet #2016
Conversation
@DeeJayElly boxes missing borders
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly you did a great job on this one. I left a few comments. Please take a look.
Also, do next: 🙏
- Add stories with connected HW, so with HW sidebar, pages etc.
- Fix flow issues
- Fix eslint issues
- You forgot to define scss variables in
thems/utils/createTheme
- Run translations manager
source/renderer/app/components/hardware-wallet/layouts/HardwareWalletWithNavigation.js
Show resolved
Hide resolved
source/renderer/app/components/hardware-wallet/settings/ConnectHardwareWallet.js
Outdated
Show resolved
Hide resolved
source/renderer/app/components/hardware-wallet/settings/ConnectHardwareWallet.js
Outdated
Show resolved
Hide resolved
source/renderer/app/components/wallet/wallet-import/WalletSelectImportDialog.js
Show resolved
Hide resolved
Added |
Done with all of these items @tomothespian |
source/renderer/app/components/hardware-wallet/layouts/HardwareWalletWithNavigation.js
Outdated
Show resolved
Hide resolved
@DeeJayElly in netlify borders disappeared UPD: and all screens are the same |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly Changes looks good. Nice job 🚀
@a-rukin can you check the latest changes? |
Well, I've checked
|
This PR adds Connecting to a Hardware wallet screens with instructions how to setup and connect your device with Daedalus.
Todos
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board