Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-131] Connecting a hardware wallet #2016

Merged
merged 33 commits into from
May 26, 2020

Conversation

DeeJayElly
Copy link
Contributor

@DeeJayElly DeeJayElly commented May 19, 2020

This PR adds Connecting to a Hardware wallet screens with instructions how to setup and connect your device with Daedalus.

Todos

  • Fix lint/flow issues
  • Adding missing elements
  • Fix scss styling issues

Screenshots

Screenshot 2020-05-20 21 32 17

Screenshot 2020-05-20 21 32 02

Screenshot 2020-05-20 21 31 48

Screenshot 2020-05-20 21 31 39

Screenshot 2020-05-20 21 31 32

Screenshot 2020-05-20 21 31 24

Screenshot 2020-05-20 21 31 13

Screenshot 2020-05-20 21 31 05

Screenshot 2020-05-25 09 11 08


Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@nikolaglumac nikolaglumac changed the title [DDW-131] - Connecting a hardware wallet [DDW-131] Connecting a hardware wallet May 19, 2020
@alexander-rukin
Copy link
Contributor

alexander-rukin commented May 21, 2020

image

@DeeJayElly boxes missing borders
  • regular border color = input border coor
  • active item border color = link color
  • error item border color = theme-red

@DeeJayElly DeeJayElly added the WIP label May 21, 2020
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly you did a great job on this one. I left a few comments. Please take a look.
Also, do next: 🙏

  1. Add stories with connected HW, so with HW sidebar, pages etc.
  2. Fix flow issues
  3. Fix eslint issues
  4. You forgot to define scss variables in thems/utils/createTheme
  5. Run translations manager

@DeeJayElly
Copy link
Contributor Author

image

@DeeJayElly boxes missing borders

  • regular border color = input border coor
  • active item border color = link color
  • error item border color = theme-red

Added

@alexander-rukin
Copy link
Contributor

image

middle border is doubled can we remove non-active one?

@DeeJayElly
Copy link
Contributor Author

  • Add stories with connected HW, so with HW sidebar, pages etc.
  • Fix flow issues
  • Fix eslint issues
  • You forgot to define scss variables in thems/utils/createTheme
  • Run translations manager

Done with all of these items @tomothespian

@DeeJayElly DeeJayElly removed the WIP label May 25, 2020
@DeeJayElly DeeJayElly requested a review from a team May 25, 2020 16:21
@alexander-rukin
Copy link
Contributor

alexander-rukin commented May 25, 2020

@DeeJayElly in netlify borders disappeared

image

UPD: and all screens are the same

@DeeJayElly
Copy link
Contributor Author

@DeeJayElly in netlify borders disappeared

image

UPD: and all screens are the same

Fixed

@DeeJayElly DeeJayElly removed the WIP label May 26, 2020
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeeJayElly Changes looks good. Nice job 🚀

@tomislavhoracek
Copy link
Contributor

@a-rukin can you check the latest changes?

@alexander-rukin
Copy link
Contributor

Well, I've checked
Steps looks ok
I'm curious if this PR will include:

  • theming
  • specific cases when we detect specific device (atm trezor has image with 3 devices and ledger with 2)

@nikolaglumac nikolaglumac merged commit 95a21f9 into develop May 26, 2020
@iohk-bors iohk-bors bot deleted the feature/ddw-131-connecting-a-hardware-wallet branch May 26, 2020 10:33
@nikolaglumac nikolaglumac added release-1.0.0-STN1 Daedalus Shelley Testnet and removed ⏳release-vNext labels Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-1.0.0-STN1 Daedalus Shelley Testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants