-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-267]: Fix data displayed outside component on transaction list screen #2033
[DDW-267]: Fix data displayed outside component on transaction list screen #2033
Conversation
2617674
to
2de1836
Compare
@yakovkaravelov I believe you will have to reach out to @DominikGuzei and discuss the virtual list implementation with him. We probably need to reconfigure it for these long addresses. |
@gnpf i cannot reproduce these issues on osx with ITN selfnode - can you confirm that this is only happening on Windows? Also i saw that you are using the |
@DominikGuzei I still can reproduce this issue on Mac I have used SN, FF and also MN to test this, happens on any network, I just used any wallet with ADA or transactions |
@gnpf are you 100% sure that you are using the build from this PR? I will test this now with the build from CI (because my local build works flawlessly) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good 🚀
This PR fixed transaction list screen showing data outside the component when resizing window.
Jira Ticket
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board