Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-267]: Fix data displayed outside component on transaction list screen #2033

Merged
merged 6 commits into from
Jun 20, 2020

Conversation

topseniors
Copy link
Contributor

This PR fixed transaction list screen showing data outside the component when resizing window.
Jira Ticket

Testing Checklist

  • Slack QA thread
  • Resize app window on transaction list screen to see if data is displayed outside the component

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@topseniors topseniors force-pushed the fix/ddw-267-data-outside-transactions-component branch from 2617674 to 2de1836 Compare June 12, 2020 08:34
@gabriela-ponce
Copy link

@yakovkaravelov When the window is maximized and you restore the size, a part of the transaction is not visible.

K1DbGgOPTS

It also happens when you resize "manually", it's adjusted after scrolling though.

qYKOjQTaFp

@nikolaglumac
Copy link
Contributor

@yakovkaravelov I believe you will have to reach out to @DominikGuzei and discuss the virtual list implementation with him. We probably need to reconfigure it for these long addresses.

@DominikGuzei
Copy link
Member

@gnpf i cannot reproduce these issues on osx with ITN selfnode - can you confirm that this is only happening on Windows? Also i saw that you are using the friends & family ITN version - is that the same?

@gabriela-ponce
Copy link

@DominikGuzei I still can reproduce this issue on Mac

image

I have used SN, FF and also MN to test this, happens on any network, I just used any wallet with ADA or transactions

@DominikGuzei
Copy link
Member

@gnpf are you 100% sure that you are using the build from this PR? I will test this now with the build from CI (because my local build works flawlessly)

Copy link

@gabriela-ponce gabriela-ponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good 🚀

@DominikGuzei DominikGuzei merged commit f62ac28 into develop Jun 20, 2020
@DominikGuzei DominikGuzei deleted the fix/ddw-267-data-outside-transactions-component branch June 20, 2020 16:00
@DominikGuzei DominikGuzei removed the WIP label Jun 20, 2020
@nikolaglumac nikolaglumac added release-1.1.0-STN1 Daedalus Shelley Testnet and removed ⏳release-vNext labels Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-1.1.0-STN1 Daedalus Shelley Testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants