-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-269] Automatic Daedalus updates #2056
[DDW-269] Automatic Daedalus updates #2056
Conversation
@daniloprates Great work! The update is now working on Linux. Here are a few unexpected behaviors I found on 14452: 1 - The update in Linux is working, but there are a lot of console errors. Here are a screenshot and the details for the errors I managed to capture. 2 - If the .crdownload file on "Downloads" is deleted and Daedalus reopen, the download resumes and completes, but a new .crdownload is visible on the folder instead of the pkg, exe or bin. 3 - As a continuation of the previous issue, if you click "update and restart" on Linux, Daedalus updates, even if the corresponding bin file is not present in "Downloads". I'll wait until @mioriohk and @ManusMcCole test this to update the summary. |
@daniloprates @cleverca22 The testing summary is updated on the description of this PR. |
report progress for daedalus to render
@daniloprates For 14467, there are a couple of issues with the download file: 1 - The progress bar is displayed even if the file is already downloaded. 2 - The update file is downloaded everytime Daedalus is open. 3 - The "Update available" screen is never displayed after the bar reaches 100%. Also a console error is visible. These are partial results on Mac. I'll test on Win and Lin and update this if I found further issues. |
@daniloprates @cleverca22 1 - The issues with the update file are fixed. |
Hi @Danilo and @cleverca22 Here is a summary of our findings for build 14475 1.The progress bar is working as expected. 2.The update is working correctly on all OS 3.Logging messages are still appearing in the console on Linux as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @daniloprates 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @daniloprates and @cleverca22 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @daniloprates 🎉
Proud of you 😄 💯
This PR implements Daedalus app automatic update.
Todos
E2E Tests(it will be handled by DDW-353)Testing Checklist
Builds:
2.1.0
2.2.0
Scenarios
Testing
2.1.0
build.2.1.0
build.Flowchart
QA Testing
Testing sheet
Build 14478:
As expected:
1 - The notification bell is visible
2 - The item is displayed on the Newsfeed first. It doesn't share the scrollbar with the rest of the items.
3 - The "Update available" overlay is displayed
4 - The "postpone" link works as expected. It is disabled/hidden when the “Close and update” button is clicked
5 - Update is successful on all platforms
6 - The Information to update manually is displayed
7 - A progress bar is displayed on Linux while the update is performed.
Fixed
1 - The progress bar is displayed on Linux.
Pending
1 - The logging is still visible on Linux.
Screenshots
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board