-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-283]: Quick fix on stake pools ranking panel #2063
Merged
nikolaglumac
merged 53 commits into
develop
from
feature/ddw-283-stake-pool-ranking-based-on-delegated-amount
Jul 15, 2020
Merged
[DDW-283]: Quick fix on stake pools ranking panel #2063
nikolaglumac
merged 53 commits into
develop
from
feature/ddw-283-stake-pool-ranking-based-on-delegated-amount
Jul 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-delegated-amount
…mount' of github.com:input-output-hk/daedalus into feature/ddw-283-stake-pool-ranking-based-on-delegated-amount
…mount' of github.com:input-output-hk/daedalus into feature/ddw-283-stake-pool-ranking-based-on-delegated-amount
…mount' of github.com:input-output-hk/daedalus into feature/ddw-283-stake-pool-ranking-based-on-delegated-amount
…ndler on stake pool ranking panel
…n stake pools ranking panel
alan-mcnicholas
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this and with zero wallets I am not seeing the dropdown as intended. After creating wallets I can see them in the dropdown with the correct balances and after deleting all wallets the UI reverts to the previous and correct state of no dropdown. Great work! :)
iohk-bors
bot
deleted the
feature/ddw-283-stake-pool-ranking-based-on-delegated-amount
branch
July 15, 2020 06:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed stake pools ranking panel which was showing wallet selector dropdown even when there is no wallet.
Hiding it when no wallets now.
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board